You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by ad...@apache.org on 2017/01/12 08:23:30 UTC
[6/8] kudu git commit: tpch: dont clear data when loading is disabled
tpch: dont clear data when loading is disabled
Previously, the benchmark would clear the minicluster data on every
startup, even if 'tpch_load_data' was disabled. With this change, we
only clear the minicluster when we are loading fresh data.
Change-Id: Ieb20f008dd6c5d530e0ba0a6aad21b377e3cc37a
Reviewed-on: http://gerrit.cloudera.org:8080/5691
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/1fec58a2
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/1fec58a2
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/1fec58a2
Branch: refs/heads/master
Commit: 1fec58a2d92067a86edda61f96ad85df0f8bf2a5
Parents: d9bd5b8
Author: Todd Lipcon <to...@apache.org>
Authored: Wed Jan 11 17:11:15 2017 -0800
Committer: Adar Dembo <ad...@cloudera.com>
Committed: Thu Jan 12 08:21:26 2017 +0000
----------------------------------------------------------------------
src/kudu/benchmarks/tpch/tpch_real_world.cc | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/1fec58a2/src/kudu/benchmarks/tpch/tpch_real_world.cc
----------------------------------------------------------------------
diff --git a/src/kudu/benchmarks/tpch/tpch_real_world.cc b/src/kudu/benchmarks/tpch/tpch_real_world.cc
index 562a6fb..349c8bc 100644
--- a/src/kudu/benchmarks/tpch/tpch_real_world.cc
+++ b/src/kudu/benchmarks/tpch/tpch_real_world.cc
@@ -153,10 +153,12 @@ const char* TpchRealWorld::kLineItemBase = "lineitem.tbl";
Status TpchRealWorld::Init() {
Env* env = Env::Default();
if (FLAGS_tpch_use_mini_cluster) {
- if (env->FileExists(FLAGS_tpch_mini_cluster_base_dir)) {
- RETURN_NOT_OK(env->DeleteRecursively(FLAGS_tpch_mini_cluster_base_dir));
+ if (FLAGS_tpch_load_data) {
+ if (env->FileExists(FLAGS_tpch_mini_cluster_base_dir)) {
+ RETURN_NOT_OK(env->DeleteRecursively(FLAGS_tpch_mini_cluster_base_dir));
+ }
+ RETURN_NOT_OK(env->CreateDir(FLAGS_tpch_mini_cluster_base_dir));
}
- RETURN_NOT_OK(env->CreateDir(FLAGS_tpch_mini_cluster_base_dir));
ExternalMiniClusterOptions opts;
opts.num_tablet_servers = 1;