You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/13 03:55:20 UTC

[GitHub] [rocketmq-connect] odbozhou commented on a diff in pull request #391: [ISSUE #337]bug fix

odbozhou commented on code in PR #391:
URL: https://github.com/apache/rocketmq-connect/pull/391#discussion_r1046633929


##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerSinkTask.java:
##########
@@ -558,8 +558,11 @@ private ConnectRecord convertMessages(MessageExt message) {
         }
 
         // add extension
-        addExtension(properties, record);
-        return record;
+        addExtension(properties, transformedRecord);
+
+        // add msgId to extension
+        transformedRecord.addExtension("MQ-SYS-MSG_ID", message.getMsgId());

Review Comment:
   Why increase MQ-SYS-MSG_ID alone? If it is necessary to increase whether it can be put in the addExtension method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org