[GitHub] necouchman commented on a change in pull request #353: GUACAMOLE-577: Support for configuring the Guacamole Proxy in LDAP Connections

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #353: GUACAMOLE-577: Support for configuring the Guacamole Proxy in LDAP Connections
URL: https://github.com/apache/guacamole-client/pull/353#discussion_r249611660
 
 

 ##########
 File path: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
 ##########
 @@ -167,18 +201,34 @@
                             // Parse name
                             String name = parameter.substring(0, equals);
                             String value = parameter.substring(equals+1);
-
-                            config.setParameter(name, value);
+                            
+                            // Pull out and set proxy parameters, if present
+                            // Otherwise set the parameter.
+                            switch(name) {
+                                case PROXY_HOST_PARAMETER:
 
 Review comment:
   Cool.  Would you rather go ahead and make those changes in this PR, or go the route of separating that into another issue (I'd already opened a separate JIRA issue for it...)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services