You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/03/18 23:23:16 UTC

[GitHub] [druid] samarthjain opened a new pull request #11013: Fix regression introduced by #11008

samarthjain opened a new pull request #11013:
URL: https://github.com/apache/druid/pull/11013


   Fixes #11012 .
   
   This PR has:
   - [X ] been self-reviewed.
      - [X ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [X] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s merged pull request #11013: Fix regression introduced by #11008

Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11013:
URL: https://github.com/apache/druid/pull/11013


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] abhishekagarwal87 commented on pull request #11013: Fix regression introduced by #11008

Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #11013:
URL: https://github.com/apache/druid/pull/11013#issuecomment-802924002


   LGTM 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] samarthjain commented on a change in pull request #11013: Fix regression introduced by #11008

Posted by GitBox <gi...@apache.org>.
samarthjain commented on a change in pull request #11013:
URL: https://github.com/apache/druid/pull/11013#discussion_r597458727



##########
File path: server/src/main/java/org/apache/druid/server/security/AuthorizationUtils.java
##########
@@ -263,10 +263,6 @@ public static Access authorizeAllResourceActions(
       throw new ISE("No authorizer found with name: [%s].", authenticationResult.getAuthorizerName());
     }
 
-    if (authorizer instanceof AllowAllAuthorizer) {
-      return resources;
-    }
-

Review comment:
       Good call, @suneet-s . I added a unit test in the new commit and in the process  I found that we can still skip authorizing the resources when AllowAllAuthorizer is configured.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] suneet-s commented on a change in pull request #11013: Fix regression introduced by #11008

Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #11013:
URL: https://github.com/apache/druid/pull/11013#discussion_r597308448



##########
File path: server/src/main/java/org/apache/druid/server/security/AuthorizationUtils.java
##########
@@ -263,10 +263,6 @@ public static Access authorizeAllResourceActions(
       throw new ISE("No authorizer found with name: [%s].", authenticationResult.getAuthorizerName());
     }
 
-    if (authorizer instanceof AllowAllAuthorizer) {
-      return resources;
-    }
-

Review comment:
       Could we add a test to prevent someone accidentally making this addition in the future. I read the previous patch and thought this was a good optimization too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org