[GitHub] [tvm] areusch commented on a diff in pull request #11673: [ci][docker] Automatically update docker images

[GitBox <gi...@apache.org>]

areusch commented on code in PR #11673:
URL: https://github.com/apache/tvm/pull/11673#discussion_r896049130


##########
jenkins/Prepare.groovy.j2:
##########
@@ -161,13 +154,32 @@ def prepare() {
         skip_slow_tests = should_skip_slow_tests(env.CHANGE_ID)
         rebuild_docker_images = sh (
           returnStatus: true,
-          script: './tests/scripts/git_change_docker.sh',
+          script: './tests/scripts/should_rebuild_docker.py',
           label: 'Check for any docker changes',
         )
         if (skip_ci) {
           // Don't rebuild when skipping CI
           rebuild_docker_images = false
         }
+        if (!rebuild_docker_images) {
+          // Pull image names from the results of should_rebuild_docker.py
+          if (env.USE_AUTOUPDATED_DOCKER_IMAGES == 'yes') {
+            {% for image in images %}
+            {{ image.name }} = sh(
+              script: "cat .docker-image.names/{{ image.name }}",

Review Comment:
   also here



##########
Jenkinsfile:
##########
@@ -274,13 +262,70 @@ def prepare() {
         skip_slow_tests = should_skip_slow_tests(env.CHANGE_ID)
         rebuild_docker_images = sh (
           returnStatus: true,
-          script: './tests/scripts/git_change_docker.sh',
+          script: './tests/scripts/should_rebuild_docker.py',
           label: 'Check for any docker changes',
         )
         if (skip_ci) {
           // Don't rebuild when skipping CI
           rebuild_docker_images = false
         }
+        if (!rebuild_docker_images) {
+          // Pull image names from the results of should_rebuild_docker.py
+          if (env.USE_AUTOUPDATED_DOCKER_IMAGES == 'yes') {
+            ci_arm = sh(
+              script: "cat .docker-image.names/ci_arm",

Review Comment:
   need to be consistent with `.gitignore` (docker-image.names vs docker-image-names)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org