You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/19 06:27:59 UTC
[GitHub] [fineract] tapaswenipathak opened a new pull request, #2608: Add transaction idempotency customer docs
tapaswenipathak opened a new pull request, #2608:
URL: https://github.com/apache/fineract/pull/2608
## Description
Ref: https://github.com/openMF/mifos-documentation/issues/14.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #2608: Add transaction idempotency customer docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2608: Add transaction idempotency customer docs
URL: https://github.com/apache/fineract/pull/2608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2608: Add transaction idempotency customer docs
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2608:
URL: https://github.com/apache/fineract/pull/2608#discussion_r991458574
##########
fineract-doc/src/docs/en/chapters/documentation/transaction-idempotency.adoc:
##########
@@ -0,0 +1,118 @@
+= Introducing Transaction Idempotency into Fineract
+
+For banks, Apache Fineract is introducing transaction idempotency, business and
+effective date configuration as an addition to currenty supported
+
+* System date
Review Comment:
Is there a reason to mixing up the idempotency concept with dates? I don't get it.
##########
fineract-doc/src/docs/en/chapters/documentation/transaction-idempotency.adoc:
##########
@@ -0,0 +1,118 @@
+= Introducing Transaction Idempotency into Fineract
+
+For banks, Apache Fineract is introducing transaction idempotency, business and
+effective date configuration as an addition to currenty supported
+
+* System date
+* Tenant date
+* User-provided date
+
+Transaction idempotency is the scenario in POST and PUT API requests when if the
+caller sends retry of a request multiple times, the result is equivalent to
+single request modification. If there is no transaction idempotency, the user
+retries the request N times, the result will end up having N resources with N
+different URIs created on server.
+
+In simple terms transaction idempotency is required in case of:
+
+* Retry of write operation in case of timeout due to:
+ * VM Crash
+ * JVM Crash
+ * Thread exception
+ * APIs crashe
Review Comment:
typo
##########
fineract-doc/src/docs/en/chapters/documentation/transaction-idempotency.adoc:
##########
@@ -0,0 +1,118 @@
+= Introducing Transaction Idempotency into Fineract
+
+For banks, Apache Fineract is introducing transaction idempotency, business and
+effective date configuration as an addition to currenty supported
+
+* System date
+* Tenant date
+* User-provided date
+
+Transaction idempotency is the scenario in POST and PUT API requests when if the
+caller sends retry of a request multiple times, the result is equivalent to
+single request modification. If there is no transaction idempotency, the user
+retries the request N times, the result will end up having N resources with N
+different URIs created on server.
+
+In simple terms transaction idempotency is required in case of:
+
+* Retry of write operation in case of timeout due to:
+ * VM Crash
+ * JVM Crash
+ * Thread exception
+ * APIs crashe
+
+* Duplicate writes
Review Comment:
Wrong indentation.
##########
fineract-doc/src/docs/en/chapters/documentation/transaction-idempotency.adoc:
##########
@@ -0,0 +1,118 @@
+= Introducing Transaction Idempotency into Fineract
+
+For banks, Apache Fineract is introducing transaction idempotency, business and
+effective date configuration as an addition to currenty supported
+
+* System date
+* Tenant date
+* User-provided date
+
+Transaction idempotency is the scenario in POST and PUT API requests when if the
Review Comment:
Not only POST and PUT. DELETE/PATCH too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2608: Add transaction idempotency customer docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #2608:
URL: https://github.com/apache/fineract/pull/2608#issuecomment-1316070177
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org