[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4430: DNSSEC refresh breaks on DS if KSK and ZSK both are expired

[GitBox <gi...@apache.org>]

rawlinp commented on a change in pull request #4430: DNSSEC refresh breaks on DS if KSK and ZSK both are expired
URL: https://github.com/apache/trafficcontrol/pull/4430#discussion_r382850282
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/cdn/dnssecrefresh.go
 ##########
 @@ -251,6 +251,10 @@ func doDNSSECKeyRefresh(tx *sql.Tx, cfg *config.Config) {
 				if err != nil {
 					log.Errorln("refreshing DNSSEC Keys: regenerating expired ZSK keys for ds '" + string(ds.DSName) + "': " + err.Error())
 				} else {
+					if existingNewKeys, ok := keys[string(ds.DSName)]; ok {
 
 Review comment:
   So, I'm not entirely convinced this is correct. The `regenExpiredKeys` function is supposed to return the right keyset to put in the `keys` map -- take a look at https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/cdn/genksk.go#L233-L239
   
   We have to be extremely careful with DNSSEC keys, and the existing code _seems_ to match up w/ what the Perl did. Does this mean Perl had this bug? And maybe we just didn't catch it because generally the KSK and ZSK expire at different intervals?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services