[GitHub] [superset] cccs-RyanS commented on issue #17852: [SIP-78] Proposal for Business Types

[GitBox <gi...@apache.org>]

cccs-RyanS commented on issue #17852:
URL: https://github.com/apache/superset/issues/17852#issuecomment-999819289


   Thanks for the feedback @betodealmeida @rusackas I really appreciate the interest!
   
   So first addressing the idea of having a plugin system, we are 100% on board and had that in mind as well, we were just unsure if introducing this idea might be a separate SIP,  extra feature or something long those lines. This could also address the idea of having some of these validators / types / etc be pre-canned and but also extensible as you both have mentioned, I think this is certainly a good idea. 
   
   in in addition `v1/business_type/types` will be used to populate a select control to populate a drop-down to select the business type. just so users don't get into weird situations selecting types that don't exist and such.
   
   I was unaware about the changes to `BaseColumn` so implementing this on the new `Column` model does make sense to me.
   
   at this time I do not have a ton of insight into how this fits into known/proposed/speculated plans for Superset's semantic layer but am willing to take on any feedback in regards to this. 
   
   Thanks again for the feedback! 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org