You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/04 02:52:02 UTC

[GitHub] [kafka] dengziming commented on a change in pull request #10129: KAFKA-10817; Add clusterId validation to Fetch handling

dengziming commented on a change in pull request #10129:
URL: https://github.com/apache/kafka/pull/10129#discussion_r587013245



##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -959,6 +972,10 @@ private FetchResponseData buildEmptyFetchResponse(
     ) {
         FetchRequestData request = (FetchRequestData) requestMetadata.data;
 
+        if (!hasValidClusterId(request)) {

Review comment:
       We only validate `FetchRequest` here? should we also add validation to the other 4 rpcs?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org