You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/20 08:45:22 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #568: [refactor][bug] bind params to struct error should response error with 400 status
nic-chen opened a new issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568
now it response normal.
here is an example:
```
$ curl http://127.0.0.1:8080/apisix/admin/services/1 -X PUT -i -d '
{
"upstream": {
"nodes": {
"127.0.0.1:8080": 1
},
"type": "roundrobin"
},
"labels": {
"env": ["production", "release"]
},
"desc": "new service"
}'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
error format of`env`
```
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
miss` ,` in json
```
{
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uris": ["/hello","/status"]
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http. StatusBadRequest,
Sleep: sleepTime,
}
```
bad `methods`
```
{
caseDesc: "add route with invalid uri",
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"methods": [99999999999999999],
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http. StatusBadRequest,
},
```
bad `priority`
```
{
caseDesc: "add route with invalid data type priority",
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"priority": "dfssdfs",
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734659552
> I think `JSON Schema` can check this case
It has returned before the json schema verification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
error `env`
```
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
miss` ,`
```
{
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uris": ["/hello","/status"]
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusOK,
Sleep: sleepTime,
}
```
bad methods
```
{
caseDesc: "add route with invalid uri",
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"methods": [99999999999999999],
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusOK,
},
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-712942988
@ShiningRush please take a look~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
```testcase
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
error `env`
```
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
miss` ,`
```
{
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uris": ["/hello","/status"]
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http. StatusBadRequest,
Sleep: sleepTime,
}
```
bad `methods`
```
{
caseDesc: "add route with invalid uri",
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"methods": [99999999999999999],
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http. StatusBadRequest,
},
```
bad `priority`
```
{
caseDesc: "add route with invalid data type priority",
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"priority": "dfssdfs",
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734052109
I think `JSON Schema` can check this case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
nic-chen closed issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
ShiningRush commented on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-714211071
I'm still considering the solution, if there are any results, I will sync here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta commented on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
```testcase
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
```testcase
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
error `env`
```
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
miss` ,`
```
{
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"upstream": {
"type": "roundrobin"
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
Sleep: sleepTime,
}
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
error `env`
```
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
miss` ,`
```
{
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uris": ["/hello","/status"]
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusOK,
Sleep: sleepTime,
}
```
bad `methods`
```
{
caseDesc: "add route with invalid uri",
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"methods": [99999999999999999],
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusOK,
},
```
bad `priority`
```
{
caseDesc: "add route with invalid data type priority",
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"priority": "dfssdfs",
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
```error `env`
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
``` miss` ,`
{
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"upstream": {
"type": "roundrobin"
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
Sleep: sleepTime,
}
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-714214855
if this is not urgent, feel free to move it to milestone 2.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
error `env`
```
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
miss` ,`
```
{
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uris": ["/hello","/status"]
"upstream": {
"type": "roundrobin",
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusOK,
Sleep: sleepTime,
}
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-714176738
ping @ShiningRush
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #568: [refactor][bug] bind params to struct error should response error with 400 status
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on issue #568:
URL: https://github.com/apache/apisix-dashboard/issues/568#issuecomment-734043715
```error `env`
{
caseDesc: "create consumers with invalid format of label value",
Object: MangerApiExpect(t),
Path: "/apisix/admin/consumers",
Method: http.MethodPost,
Body: `{
"username":"case_10",
"desc": "new consumer",
"labels": {
"env": ["production", "release"]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
},
```
``` miss` ,`
{
Object: MangerApiExpect(t),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
"uri": "/hello",
"upstream": {
"type": "roundrobin"
"nodes": [{
"host": "172.16.238.20",
"port": 1980,
"weight": 1
}]
}
}`,
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusBadRequest,
Sleep: sleepTime,
}
```
it return 200 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org