You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "tm_jee (JIRA)" <ji...@apache.org> on 2007/02/16 08:39:17 UTC
[jira] Created: (WW-1744) Support Sitemesh's applyDecorator tag
using Freemarker Transform
Support Sitemesh's applyDecorator tag using Freemarker Transform
----------------------------------------------------------------
Key: WW-1744
URL: https://issues.apache.org/struts/browse/WW-1744
Project: Struts 2
Issue Type: Improvement
Reporter: tm_jee
this is a port from http://jira.opensymphony.com/browse/WW-1425
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-1744) Support Sitemesh's applyDecorator tag
using Freemarker Transform
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-1744:
--------------------------
Fix Version/s: (was: 2.1.1)
2.1.x
> Support Sitemesh's applyDecorator tag using Freemarker Transform
> ----------------------------------------------------------------
>
> Key: WW-1744
> URL: https://issues.apache.org/struts/browse/WW-1744
> Project: Struts 2
> Issue Type: Improvement
> Reporter: tm_jee
> Fix For: 2.1.x
>
>
> this is a port from http://jira.opensymphony.com/browse/WW-1425
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-1744) Support Sitemesh's applyDecorator tag
using Freemarker Transform
Posted by "tm_jee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
tm_jee updated WW-1744:
-----------------------
Fix Version/s: (was: 2.0.8)
Future
marking this as fixed for future, just in case someothers might want to have a go at it.
cheers.
> Support Sitemesh's applyDecorator tag using Freemarker Transform
> ----------------------------------------------------------------
>
> Key: WW-1744
> URL: https://issues.apache.org/struts/browse/WW-1744
> Project: Struts 2
> Issue Type: Improvement
> Reporter: tm_jee
> Fix For: Future
>
>
> this is a port from http://jira.opensymphony.com/browse/WW-1425
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-1744) Support Sitemesh's applyDecorator tag
using Freemarker Transform
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-1744:
--------------------------
Fix Version/s: (was: 2.1.x)
2.2.x
> Support Sitemesh's applyDecorator tag using Freemarker Transform
> ----------------------------------------------------------------
>
> Key: WW-1744
> URL: https://issues.apache.org/struts/browse/WW-1744
> Project: Struts 2
> Issue Type: Improvement
> Reporter: tm_jee
> Fix For: 2.2.x
>
>
> this is a port from http://jira.opensymphony.com/browse/WW-1425
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-1744) Support Sitemesh's applyDecorator tag
using Freemarker Transform
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Husted updated WW-1744:
---------------------------
Flags: [Patch]
Fix Version/s: 2.0.7
> Support Sitemesh's applyDecorator tag using Freemarker Transform
> ----------------------------------------------------------------
>
> Key: WW-1744
> URL: https://issues.apache.org/struts/browse/WW-1744
> Project: Struts 2
> Issue Type: Improvement
> Reporter: tm_jee
> Fix For: 2.0.7
>
>
> this is a port from http://jira.opensymphony.com/browse/WW-1425
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-1744) Support Sitemesh's applyDecorator tag
using Freemarker Transform
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40518 ]
Ted Husted commented on WW-1744:
--------------------------------
Ummm, did you forget to annex the patch Toby?
If you still have it, just go ahead and apply it.
-Ted.
> Support Sitemesh's applyDecorator tag using Freemarker Transform
> ----------------------------------------------------------------
>
> Key: WW-1744
> URL: https://issues.apache.org/struts/browse/WW-1744
> Project: Struts 2
> Issue Type: Improvement
> Reporter: tm_jee
> Fix For: 2.0.7
>
>
> this is a port from http://jira.opensymphony.com/browse/WW-1425
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-1744) Support Sitemesh's applyDecorator tag
using Freemarker Transform
Posted by "tm_jee (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40521 ]
tm_jee commented on WW-1744:
----------------------------
I think someone with more insight of struts2 should take a look at this first cause
- there's a sitemesh plugin, should it belong there?
- the changes affect FreemarkerManager which is part of the core (I think). It sounds strange if part of this is in the plugin and part of it is in the core
- it uses webwork.properties, (which should be struts.properties equivalent but if not mistaken its being deprecated in favour of another configuration file) to decide if the sitemesh transform should be populated into freemarker's model.
Maybe we should leave this with WebWork and not port it to struts2.
The changes are :-
Modified: trunk\src\java\com\opensymphony\webwork\WebWorkConstants.java
Modified: trunk\src\java\com\opensymphony\webwork\components\Component.java
Modified: trunk\src\java\com\opensymphony\webwork\default.properties
Modified: trunk\src\java\com\opensymphony\webwork\views\JspSupportServlet.java
Modified: trunk\src\java\com\opensymphony\webwork\views\freemarker\FreemarkerManager.java
Adding: trunk\src\java\com\opensymphony\webwork\views\sitemesh
Adding: trunk\src\java\com\opensymphony\webwork\views\sitemesh\ApplyDecoratorBean.java
Adding: trunk\src\java\com\opensymphony\webwork\views\sitemesh\ApplyDecoratorTransform.java
Adding: trunk\src\java\com\opensymphony\webwork\views\sitemesh\SitemeshModel.java
rgds
> Support Sitemesh's applyDecorator tag using Freemarker Transform
> ----------------------------------------------------------------
>
> Key: WW-1744
> URL: https://issues.apache.org/struts/browse/WW-1744
> Project: Struts 2
> Issue Type: Improvement
> Reporter: tm_jee
> Fix For: 2.0.7
>
>
> this is a port from http://jira.opensymphony.com/browse/WW-1425
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.