[GitHub] [incubator-annotator] Treora commented on a change in pull request #67: Reorganise webpack-related files

[GitBox <gi...@apache.org>]

Treora commented on a change in pull request #67: Reorganise webpack-related files
URL: https://github.com/apache/incubator-annotator/pull/67#discussion_r399801960
 
 

 ##########
 File path: web/webpack.config.js
 ##########
 @@ -43,7 +46,7 @@ module.exports = {
     ],
   },
   output: {
-    filename: '[name].js',
-    publicPath: '/',
+    path: path.resolve(__dirname),
 
 Review comment:
   Yes, an output folder has my preference as well; it’s just really hard to get webpack to also move the html files into that output folder, and I would like html and js files to stick together. I made it work now; if we add more demo pages/files, I would consider trying out [Parcel](https://parceljs.org/) to see whether it better supports such an html-first instead of javascript-first approach.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services