[GitHub] [superset] codemaster08240328 commented on a change in pull request #19370: fix(sql lab): replace the output column in the query history table

[GitBox <gi...@apache.org>]

codemaster08240328 commented on a change in pull request #19370:
URL: https://github.com/apache/superset/pull/19370#discussion_r840779671



##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.tsx
##########
@@ -35,10 +35,12 @@ import ResultSet from '../ResultSet';
 import HighlightedSql from '../HighlightedSql';
 import { StaticPosition, verticalAlign, StyledTooltip } from './styles';
 
-interface QueryTableQuery extends Omit<Query, 'state' | 'sql' | 'progress'> {
+interface QueryTableQuery
+  extends Omit<Query, 'state' | 'sql' | 'progress' | 'output' | 'results'> {

Review comment:
       Any reason you need to omit `output` from `Query`?
   Let's keep it if we don't have specific reason.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org