[GitHub] [cloudstack] rhtyd commented on a change in pull request #4094: kvm: qemu-img convert -s to backup snapshot is deprecated

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #4094:
URL: https://github.com/apache/cloudstack/pull/4094#discussion_r427990682



##########
File path: scripts/storage/qcow2/managesnapshot.sh
##########
@@ -153,7 +153,7 @@ destroy_snapshot() {
     lvm lvremove -f "${vg}/${snapshotname}-cow"
   elif [ -f $disk ]; then
      #delete all the existing snapshots
-     $qemu_img snapshot -l $disk |tail -n +3|awk '{print $1}'|xargs -I {} $qemu_img snapshot -d {} $disk >&2
+     $qemu_img snapshot -l $disk |tail -n +3|awk '{print $2}'|xargs -I {} $qemu_img snapshot -d {} $disk >&2

Review comment:
       @shwstppr @davidjumani can any of you advise if `qemu-img snapshot -l` second column is the name of the snapshot or ID? qemu-img snapshot -d in Ubuntu 20.04 and possibly CentOS8 only accepts snapshot name and not the ID.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org