You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/03 16:37:05 UTC
[GitHub] [inlong] GanfengTan opened a new pull request, #5348: [INLONG-5347][Agent] Incremental and full reads of file contents
GanfengTan opened a new pull request, #5348:
URL: https://github.com/apache/inlong/pull/5348
This feature supports both incremental and full file content
- Fixes #5347
### Motivation
### Modifications
1.Added configuration parameters
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [x] This change added tests and can be verified as follows:
*TestTextFileReader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #5348: [INLONG-5347][Agent] Incremental and full reads of file contents
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on code in PR #5348:
URL: https://github.com/apache/inlong/pull/5348#discussion_r938380100
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/TextFileSource.java:
##########
@@ -76,6 +81,23 @@ public List<Reader> split(JobProfile jobConf) {
return result;
}
+ private int getSeekPosition(JobProfile jobConf, File file) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #5348: [INLONG-5347][Agent] Incremental and full reads of file contents
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5348:
URL: https://github.com/apache/inlong/pull/5348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #5348: [INLONG-5347][Agent] Incremental and full reads of file contents
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5348:
URL: https://github.com/apache/inlong/pull/5348#discussion_r937320726
##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/TextFileSource.java:
##########
@@ -76,6 +81,23 @@ public List<Reader> split(JobProfile jobConf) {
return result;
}
+ private int getSeekPosition(JobProfile jobConf, File file) {
Review Comment:
getStartPosition may be proper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org