[GitHub] [incubator-doris] imay commented on a change in pull request #1992: [Bug-fix][Broker-load] Fix the bug of the label already exists when the txn has been finished

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1992: [Bug-fix][Broker-load] Fix the bug of the label already exists when the txn has been finished
URL: https://github.com/apache/incubator-doris/pull/1992#discussion_r335254776
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/load/loadv2/MiniLoadJob.java
 ##########
 @@ -94,22 +94,7 @@ public void beginTxn() throws LabelAlreadyUsedException, BeginTransactionExcepti
     }
 
     @Override
-    protected void executeAfterAborted(TransactionState txnState) {
-        updateLoadingStatue(txnState);
-    }
-
-    @Override
-    protected void executeAfterVisible(TransactionState txnState) {
-        updateLoadingStatue(txnState);
-    }
-
-    @Override
-    protected void executeReplayOnAborted(TransactionState txnState) {
-        updateLoadingStatue(txnState);
-    }
-
-    @Override
-    protected void executeReplayOnVisible(TransactionState txnState) {
+    protected void executeReplayTxnAttachment(TransactionState txnState) {
 
 Review comment:
   ```suggestion
       protected void replayTxnAttachment(TransactionState txnState) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org