[GitHub] [airflow] OmerJog commented on issue #6795: Adjust the MASTER_URL of spark-submit in SparkSubmitHook

[GitBox <gi...@apache.org>]

OmerJog commented on issue #6795: Adjust the MASTER_URL of spark-submit in SparkSubmitHook
URL: https://github.com/apache/airflow/pull/6795#issuecomment-566530023
 
 
   @mikolaje Tests are failing:
   
   ```
   tests/contrib/hooks/test_spark_submit_hook.py:561: 
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   airflow/contrib/hooks/spark_submit_hook.py:149: in __init__
       self._connection = self._resolve_connection()
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   self = <airflow.contrib.hooks.spark_submit_hook.SparkSubmitHook object at 0x7f72cf993048>
       def _resolve_connection(self):
           # Build from connection master or default to yarn if not available
           conn_data = {'master': 'yarn',
                        'queue': None,
                        'deploy_mode': None,
                        'spark_home': None,
                        'spark_binary': self._spark_binary or "spark-submit",
                        'namespace': None}
       
           try:
               # Master can be local, yarn, spark://HOST:PORT, mesos://HOST:PORT and
               # k8s://https://<HOST>:<PORT>
               conn = self.get_connection(self._conn_id)
               if conn.port:
                   conn_data['master'] = "{}:{}".format(conn.host, conn.port)
               else:
                   conn_data['master'] = conn.host
   >           if conn.uri_without_query:
   E           AttributeError: 'Connection' object has no attribute 'uri_without_query'
   ```
   
   Also, can you please edit your commit message to:
   `[AIRFLOW-6212] Adjust the MASTER_URL of spark-submit in SparkSubmitHook`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services