You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/30 19:40:04 UTC
[GitHub] [cordova-ios] sherburne opened a new issue #929: Cannot disable splashscreen as of Cordova iOS 6.x
sherburne opened a new issue #929:
URL: https://github.com/apache/cordova-ios/issues/929
# Bug Report
## Problem
According to the Cordova Splashscreen documentation, iOS apps should be able to disable the Cordova-provided launch splashscreen by setting SplashScreenDelay to 0 and FadeSplashScreenDuration to 0. As of 6.1.0, these settings no longer have that effect. `createLaunchView` in `CDVViewController.m` does not inspect these settings before instantiating the launch storyboard.
Reference:
https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-splashscreen/index.html#launch-storyboard-images
https://github.com/apache/cordova-ios/compare/5.1.x...6.1.x#diff-3d962b8f101cacedea7abce2ca246eac
## Checklist
<!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
- [x] I searched for existing GitHub issues
- [x] I updated all Cordova tooling to most recent version
- [x] I included all the necessary information above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] breautek commented on issue #929: Cannot disable splashscreen as of Cordova iOS 6.x
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #929:
URL: https://github.com/apache/cordova-ios/issues/929#issuecomment-651992101
I believe the default behaviour is a splashscreen is shown for 3 seconds (in addition to however long it takes for the OS to launch the app).
The documentation you linked just disables the delay, but not the splashscreen. Did you mean disabling the delay no longer works in 6.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] sherburne commented on issue #929: Cannot disable splashscreen as of Cordova iOS 6.x
Posted by GitBox <gi...@apache.org>.
sherburne commented on issue #929:
URL: https://github.com/apache/cordova-ios/issues/929#issuecomment-652000179
Here's what I'm readin in the documentation that I linked to:
> To disable the splashscreen add the following preference to config.xml: <preference name="SplashScreenDelay" value="0">
> ...
> iOS Quirk: to disable the splashscreen on ios platform you should also add <preference name="FadeSplashScreenDuration" value="0"/> to config.xml.
I'm interpreting "disable" as "the cordova code won't show the splash screen, period". I've been using Cordova inside a native app for the past year, and I hadn't seen any contention over the splash screen until the upgrade from 5.0.0 to 6.1.0.
Of course I can fork the 6.1.0 code but I'd really like to avoid that for obvious reasons. Another approach I'd considered is subclassing `CDVViewController`, but `createLaunchView` and `launchView` are private so that won't help either. I'm continuing to look at other possibilities.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] j-crosson commented on issue #929: Cannot disable splashscreen in standalone CDVViewController
Posted by GitBox <gi...@apache.org>.
j-crosson commented on issue #929:
URL: https://github.com/apache/cordova-ios/issues/929#issuecomment-652484354
I mentioned this issue in passing in a CDVViewController-leak bug report (920). Glad the issue is being addressed, guess I should have reported this as a separate issue. I have an ugly workaround that I'll use if a fix doesn't come out before I ship. Since "private" isn't really private in Objective-C, I exposed “launchView” which I replace in my subclassed ViewController “viewDidLoad”.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on issue #929: Cannot disable splashscreen as of Cordova iOS 6.x
Posted by GitBox <gi...@apache.org>.
dpogue commented on issue #929:
URL: https://github.com/apache/cordova-ios/issues/929#issuecomment-652002309
yeah, I think this is a valid issue when using `CDVViewController` as part of another application. It will unconditionally show the LaunchStoryboard/blank screen until the web page has loaded.
None of those existing preferences sound like they properly capture what you're actually trying to do here, so we might want to add a new one specific to this use case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] sherburne edited a comment on issue #929: Cannot disable splashscreen as of Cordova iOS 6.x
Posted by GitBox <gi...@apache.org>.
sherburne edited a comment on issue #929:
URL: https://github.com/apache/cordova-ios/issues/929#issuecomment-651977042
Okay - Looks like the Cordova documentation is stale then? I'm using Cordova as part of a broader native iOS project; that code manages the appearance of the splash screen. Is there a better way to disable the Cordova splash screen code that you'd recommend?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] NiklasMerz closed issue #929: Cannot disable splashscreen in standalone CDVViewController
Posted by GitBox <gi...@apache.org>.
NiklasMerz closed issue #929:
URL: https://github.com/apache/cordova-ios/issues/929
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] sherburne commented on issue #929: Cannot disable splashscreen as of Cordova iOS 6.x
Posted by GitBox <gi...@apache.org>.
sherburne commented on issue #929:
URL: https://github.com/apache/cordova-ios/issues/929#issuecomment-651977042
Okay - Looks like the Cordova documentation is stale then? I'm using Cordova as part of a broader native iOS project; that code manages the appearance of the splash screen. Is there a better way to disable the splash screen that you'd recommend?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] sherburne commented on issue #929: Cannot disable splashscreen in standalone CDVViewController
Posted by GitBox <gi...@apache.org>.
sherburne commented on issue #929:
URL: https://github.com/apache/cordova-ios/issues/929#issuecomment-652005599
Thanks, that would be a big help. Let me know if there's anything I can do to make this happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org