You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/02/14 09:21:04 UTC
DO NOT REPLY [Bug 118906] New: Support system libraries for apr,
apr-util, serf, coinmp.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
Bug #: 118906
Issue Type: DEFECT
Summary: Support system libraries for apr, apr-util, serf,
coinmp.
Classification: Code
Product: external
Version: OOO340m0
Platform: PC
OS/Version: All
Status: CONFIRMED
Severity: normal
Priority: P3
Component: www
AssignedTo: af@a-w-f.de
ReportedBy: af@a-w-f.de
CC: ooo-issues@incubator.apache.org, pfg@apache.org
Several external libraries where added recently. On some systems they are
already installed outside AOO.
Add --with-system-<module> switches to use the system installed versions.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #5 from Pedro Giffuni <pf...@apache.org> ---
Hi Andre;
To be honest, all I did was to review the lp_solve removal and adapt it to
coinmp. The tests for Ubunto were there, along with an attempt to grok a
function in the library. I think we can leave them out and wait for someone
with Ubuntu to complain ;).
Concerning the check, Lp_solve seemed to take the decision in calc/makefile.mk.
I am unsure if I shouldve used an "else" there. Further checks are certainly
better but I couldnt find them in the deprecated lp_solve.
The patch is still untested: I have to do other changes in configure.in for
binary blobs and I am yet undecided how to go around testing all of it since
builds take so long.
Once its done, this patch should also be a good guideline to do the same with
apr and serf, of course.
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118906] Support system libraries for apr,
apr-util, serf, coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #2 from Pedro Giffuni <pf...@apache.org> 2012-02-14 18:05:40 UTC ---
(In reply to comment #1)
>
> FWIW, While updating Apache Tomcat, I noted Tomcat
> appears to use APR. No idea if we should be reusing the
> same or let Tomcat use it's own: for now permitting the
> code replication is just less trouble.
Nevermind... the Tomcat documentation mentions APR but
we don't use it in our build.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #9 from Andre <af...@a-w-f.de> ---
And some more fixes to unify the use of underscores in APRUTIL/APR_UTIL.
SVN revision 1354845.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #3 from Pedro Giffuni <pf...@apache.org> ---
Created attachment 78073
--> https://issues.apache.org/ooo/attachment.cgi?id=78073&action=edit
Initial patch for detecting system coinmp
CoinMP is Category-B so it would be particularly interesting to make it
possible to use the system libraries.
I made an initial try but still missing is the change to add the .dll in
main/postprocess/rebase/coffbase.txt
I don't know what memory addresses should be used there.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #10 from Pedro Giffuni <pf...@apache.org> ---
Maho has updated the FreeBSD port to use coinmp, serf and apr and it works
fine.
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118906] Support system libraries for apr,
apr-util, serf, coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #1 from Pedro Giffuni <pf...@apache.org> 2012-02-14 16:35:39 UTC ---
Thanks for creating this issue. It is important.
FWIW, While updating Apache Tomcat, I noted Tomcat
appears to use APR. No idea if we should be reusing the
same or let Tomcat use it's own: for now permitting the
code replication is just less trouble.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #11 from Andre <af...@a-w-f.de> ---
That is great to hear. Thanks for the feedback.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
Target Milestone|--- |AOO 4.0
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
Andre <af...@a-w-f.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Issue Type|DEFECT |ENHANCEMENT
Resolution|--- |FIXED
--- Comment #6 from Andre <af...@a-w-f.de> ---
Added the switches
--with-system-apr
--with-system-apr-util
--with-system-serf
--with-system-coinmp
to allow the use of system libraries for the respective modules.
I have tested the build without the switches (but, of course, with the changes)
on Windows,Linux,Mac. I could test the active switches only on Linux because
on Windows or Mac I could not install the system libraries.
There may be issues with OS/2.
SVN revision 1354035.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #7 from Andre <af...@a-w-f.de> ---
Thanks Pedro for the patch. I used it as the basis for the CoinMP part.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #8 from Andre <af...@a-w-f.de> ---
Had to fix the dependency of scp2 on apr-util. The aprutil_version.mk has to
be delivered even when system apr-util is used and ext_libraries/apr-util is
not build.
Thanks to Yuri Dario for finding this bug.
SVN revision is 1354384.
--
You are receiving this mail because:
You are on the CC list for the bug.
[Bug 118906] Support system libraries for apr, apr-util, serf,
coinmp.
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118906
--- Comment #4 from Andre <af...@a-w-f.de> ---
If I read the rebase.pl in the same directory as coffbase.txt correctly, then
all DLLs that are not explicitly mentioned in coffbase.txt (or no_rebase.txt)
then the address is calculated automatically. The fixed addresses in
coffbase.txt are only important for binary patches to installed releases, which
we do not have anymore. For creating a full installation set, the fixed
addresses are not necessary.
I also looked at your patch. Looks good. Just one question and one remark:
Q: In the changes to configure.in I saw the lines
# some systems need this. Like Ubuntu....
AC_CHECK_LIB(m, floor)
AC_CHECK_LIB(dl, dlopen)
Can you explain why that is necessary? And, do we need them in other places,
too?
R: Maybe you can add a guard to the makefile of coinmp that excludes building
the external library when system CoinMP is used. That should not be strictly
necessary (with adding COINMP only conditionally to BUILD_TYPE) but we have
these guards in other modules.
--
You are receiving this mail because:
You are on the CC list for the bug.