[GitHub] [drill] sohami commented on a change in pull request #1677: DRILL-7068: Support memory adjustment framework for resource manageme…

[GitBox <gi...@apache.org>]

sohami commented on a change in pull request #1677: DRILL-7068: Support memory adjustment framework for resource manageme…
URL: https://github.com/apache/drill/pull/1677#discussion_r262648177
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/NodeResource.java
 ##########
 @@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.cost;
+
+import org.apache.drill.exec.proto.CoordinationProtos.DrillbitEndpoint;
+import java.util.Map;
+
+/**
+ * This class abstracts the resources like cpu and memory used up by the operators.
+ * In future network resources can also be incorporated if required.
+ */
+public class NodeResource {
+  private long cpu;
+  private long memory;
+
+  public NodeResource(long cpu, long memory) {
+    this.cpu = cpu;
+    this.memory = memory;
+  }
+
+  public void add(NodeResource other) {
+    if (other == null) {
+      return;
+    }
+    this.cpu += other.cpu;
+    this.memory += other.memory;
+  }
+
+  public long getMemory() {
+    return memory;
+  }
+
+  // A utility function to merge the node resources from one drillbit map to other drillbit map.
+  public static Map<DrillbitEndpoint, NodeResource> merge(Map<DrillbitEndpoint, NodeResource> to,
+                                                          Map<DrillbitEndpoint, NodeResource> from) {
+    to.entrySet().stream().forEach((toEntry) -> toEntry.getValue().add(from.get(toEntry.getKey())));
+    return to;
+  }
+
+  @Override
+  public String toString() {
+    StringBuilder sb = new StringBuilder();
+    sb.append("CPU: ").append(cpu).append("Memory: ").append(memory);
+    return sb.toString();
+  }
+
+  public static NodeResource create() {
+    return create(0,0);
+  }
+
+  public static NodeResource create(long cpu) {
+    return create(cpu,0);
+  }
+
+  public static NodeResource create(long cpu, long memory) {
+    return new NodeResource(cpu, memory);
+  }
 
 Review comment:
   Why not provide multiple constructors instead of static methods ? By the way we have to merge this with NodeResources provided in this [PR for DRILL-7046](https://github.com/apache/drill/pull/1652)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services