You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Christofer Dutz <ch...@c-ware.de> on 2017/01/25 15:06:11 UTC

[FlexJS] Change flex sdk descriptor?

Hi,

I’m currently working on fixing FlexJS support in IntelliJ. I just encountered a line of code in which the component sets are selected based on the version-number (if it’s greater than 4.5). I don’t want to go down the path of hacking the version number of flexJS to be something like 4.8.0.8.0 so I would rather have the version 0.8.0 but a SDK type in the descriptor. Unfortunately I don’t know if adding an element to this would break things. What other alternatives would we have to provide this information?

Chris

Re: AW: [FlexJS] Change flex sdk descriptor?

Posted by piotrz <pi...@gmail.com>.
Hi Chris,

Thank you for working on support! <3 

Every time in my Flex Development life when I touch Flash Builder I was
struggle with his slowness. - After short time I was always dropping it to
Intellij. 

Although I think Flash Builder is still being used if we can simple our own
separate config for FlexJS - Why not to do this.

How would looks like your fix Chris ? It will be in Intellij Flex plugin ?
You will do pull request and if they accept it will be part of next release
?

Piotr





-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/FlexJS-Change-flex-sdk-descriptor-tp58687p58695.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: AW: [FlexJS] Change flex sdk descriptor?

Posted by Christofer Dutz <ch...@c-ware.de>.
Ok … so the Maven build now produces a flexjs-sdk-description.xml

<flexjs-sdk-description>
  <name>Apache Flex: FlexJS 0.8.0-SNAPSHOT FP20.0 AIR20.0 en_US</name>
  <version>0.8.0-SNAPSHOT</version>
  <build>201701252211</build>
  <flavor>default</flavor>
  <default-locale>en_US</default-locale>
  <flash>
    <version>20.0</version>
  </flash>
  <air>
    <version>20.0</version>
  </air>
</flexjs-sdk-description>

And I took the opportunity to comment out a line in the team-page example as it was breaking the build …

Chris



Am 25.01.17, 22:29 schrieb "Christofer Dutz" <ch...@c-ware.de>:

    I never said to drop support for FlashBuilder. All I wanted, is to have the default distribution to be clean and to apply the FB hack on demand if necessary.
    But I’m ok with a flexjs specific descriptor. I hate doing things sloppily and definitely hate hacks like the one needed to support FB.
    
    Chris
    
    
    Am 25.01.17, 21:06 schrieb "omuppi1@gmail.com im Auftrag von OmPrakash Muppirala" <omuppi1@gmail.com im Auftrag von bigosmallm@gmail.com>:
    
        On Jan 25, 2017 10:21 AM, "Christofer Dutz" <ch...@c-ware.de>
        wrote:
        
        Hi Alex,
        
        But all the IDEs are alive and are being maintained. Flash Builder is the
        only one that's but been maintained.
        
        But I'd be ok with an additional descriptor if more people here think we
        should keep legacy stuff in a new product.
        
        
        I think we should maintain support for FB as much as possible.
        
        A lot of Flex developers already use it, so supporting that IDE would be a
        good idea to increase adoption of FlexJS.
        
        Thanks,
        Om
        
        
        Chris
        
        
        
        Von meinem Samsung Galaxy Smartphone gesendet.
        
        
        -------- Ursprüngliche Nachricht --------
        Von: Alex Harui <ah...@adobe.com>
        Datum: 25.01.17 17:34 (GMT+01:00)
        An: dev@flex.apache.org
        Betreff: Re: [FlexJS] Change flex sdk descriptor?
        
        
        
        On 1/25/17, 7:51 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
        
        >Well the thing is, that I don’t want to have to rely on a single
        >dimension of values to switch multiple dimensions of functionality. What
        >happens if people start using x > 4.8 for detecting FlexJS and assume we
        >release a regular Flex 4.8? What happens then? Things can get really ugly
        >in that case and I am sure it’s gonna happen soon ;-)
        >
        >I guess we shouldn’t force a hack in our SDK just because a no longer
        >supported legacy IDE otherwise doesn’t know how to handle it.
        
        We don't have control over many other IDEs as well, so a change here
        requires every other IDE to change.  Seems like we have more control over
        IntelliJ.
        
        What if we introduce a new file called flexjs-sdk-descriptor.xml and leave
        the old one with the hack for legacy support.  Then all IDE vendors can
        move to checking the new file when they have time?
        
        Thoughts?
        -Alex
        
    
    


Re: AW: [FlexJS] Change flex sdk descriptor?

Posted by Christofer Dutz <ch...@c-ware.de>.
I never said to drop support for FlashBuilder. All I wanted, is to have the default distribution to be clean and to apply the FB hack on demand if necessary.
But I’m ok with a flexjs specific descriptor. I hate doing things sloppily and definitely hate hacks like the one needed to support FB.

Chris


Am 25.01.17, 21:06 schrieb "omuppi1@gmail.com im Auftrag von OmPrakash Muppirala" <omuppi1@gmail.com im Auftrag von bigosmallm@gmail.com>:

    On Jan 25, 2017 10:21 AM, "Christofer Dutz" <ch...@c-ware.de>
    wrote:
    
    Hi Alex,
    
    But all the IDEs are alive and are being maintained. Flash Builder is the
    only one that's but been maintained.
    
    But I'd be ok with an additional descriptor if more people here think we
    should keep legacy stuff in a new product.
    
    
    I think we should maintain support for FB as much as possible.
    
    A lot of Flex developers already use it, so supporting that IDE would be a
    good idea to increase adoption of FlexJS.
    
    Thanks,
    Om
    
    
    Chris
    
    
    
    Von meinem Samsung Galaxy Smartphone gesendet.
    
    
    -------- Ursprüngliche Nachricht --------
    Von: Alex Harui <ah...@adobe.com>
    Datum: 25.01.17 17:34 (GMT+01:00)
    An: dev@flex.apache.org
    Betreff: Re: [FlexJS] Change flex sdk descriptor?
    
    
    
    On 1/25/17, 7:51 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
    
    >Well the thing is, that I don’t want to have to rely on a single
    >dimension of values to switch multiple dimensions of functionality. What
    >happens if people start using x > 4.8 for detecting FlexJS and assume we
    >release a regular Flex 4.8? What happens then? Things can get really ugly
    >in that case and I am sure it’s gonna happen soon ;-)
    >
    >I guess we shouldn’t force a hack in our SDK just because a no longer
    >supported legacy IDE otherwise doesn’t know how to handle it.
    
    We don't have control over many other IDEs as well, so a change here
    requires every other IDE to change.  Seems like we have more control over
    IntelliJ.
    
    What if we introduce a new file called flexjs-sdk-descriptor.xml and leave
    the old one with the hack for legacy support.  Then all IDE vendors can
    move to checking the new file when they have time?
    
    Thoughts?
    -Alex
    


Re: AW: [FlexJS] Change flex sdk descriptor?

Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Jan 25, 2017 10:21 AM, "Christofer Dutz" <ch...@c-ware.de>
wrote:

Hi Alex,

But all the IDEs are alive and are being maintained. Flash Builder is the
only one that's but been maintained.

But I'd be ok with an additional descriptor if more people here think we
should keep legacy stuff in a new product.


I think we should maintain support for FB as much as possible.

A lot of Flex developers already use it, so supporting that IDE would be a
good idea to increase adoption of FlexJS.

Thanks,
Om


Chris



Von meinem Samsung Galaxy Smartphone gesendet.


-------- Ursprüngliche Nachricht --------
Von: Alex Harui <ah...@adobe.com>
Datum: 25.01.17 17:34 (GMT+01:00)
An: dev@flex.apache.org
Betreff: Re: [FlexJS] Change flex sdk descriptor?



On 1/25/17, 7:51 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Well the thing is, that I don’t want to have to rely on a single
>dimension of values to switch multiple dimensions of functionality. What
>happens if people start using x > 4.8 for detecting FlexJS and assume we
>release a regular Flex 4.8? What happens then? Things can get really ugly
>in that case and I am sure it’s gonna happen soon ;-)
>
>I guess we shouldn’t force a hack in our SDK just because a no longer
>supported legacy IDE otherwise doesn’t know how to handle it.

We don't have control over many other IDEs as well, so a change here
requires every other IDE to change.  Seems like we have more control over
IntelliJ.

What if we introduce a new file called flexjs-sdk-descriptor.xml and leave
the old one with the hack for legacy support.  Then all IDE vendors can
move to checking the new file when they have time?

Thoughts?
-Alex

AW: [FlexJS] Change flex sdk descriptor?

Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Alex,

But all the IDEs are alive and are being maintained. Flash Builder is the only one that's but been maintained.

But I'd be ok with an additional descriptor if more people here think we should keep legacy stuff in a new product.

Chris



Von meinem Samsung Galaxy Smartphone gesendet.


-------- Ursprüngliche Nachricht --------
Von: Alex Harui <ah...@adobe.com>
Datum: 25.01.17 17:34 (GMT+01:00)
An: dev@flex.apache.org
Betreff: Re: [FlexJS] Change flex sdk descriptor?



On 1/25/17, 7:51 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Well the thing is, that I don’t want to have to rely on a single
>dimension of values to switch multiple dimensions of functionality. What
>happens if people start using x > 4.8 for detecting FlexJS and assume we
>release a regular Flex 4.8? What happens then? Things can get really ugly
>in that case and I am sure it’s gonna happen soon ;-)
>
>I guess we shouldn’t force a hack in our SDK just because a no longer
>supported legacy IDE otherwise doesn’t know how to handle it.

We don't have control over many other IDEs as well, so a change here
requires every other IDE to change.  Seems like we have more control over
IntelliJ.

What if we introduce a new file called flexjs-sdk-descriptor.xml and leave
the old one with the hack for legacy support.  Then all IDE vendors can
move to checking the new file when they have time?

Thoughts?
-Alex


Re: [FlexJS] Change flex sdk descriptor?

Posted by Alex Harui <ah...@adobe.com>.

On 1/25/17, 7:51 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Well the thing is, that I don’t want to have to rely on a single
>dimension of values to switch multiple dimensions of functionality. What
>happens if people start using x > 4.8 for detecting FlexJS and assume we
>release a regular Flex 4.8? What happens then? Things can get really ugly
>in that case and I am sure it’s gonna happen soon ;-)
>
>I guess we shouldn’t force a hack in our SDK just because a no longer
>supported legacy IDE otherwise doesn’t know how to handle it.

We don't have control over many other IDEs as well, so a change here
requires every other IDE to change.  Seems like we have more control over
IntelliJ.

What if we introduce a new file called flexjs-sdk-descriptor.xml and leave
the old one with the hack for legacy support.  Then all IDE vendors can
move to checking the new file when they have time?

Thoughts?
-Alex


Re: [FlexJS] Change flex sdk descriptor?

Posted by Christofer Dutz <ch...@c-ware.de>.
Well the thing is, that I don’t want to have to rely on a single dimension of values to switch multiple dimensions of functionality. What happens if people start using x > 4.8 for detecting FlexJS and assume we release a regular Flex 4.8? What happens then? Things can get really ugly in that case and I am sure it’s gonna happen soon ;-)

I guess we shouldn’t force a hack in our SDK just because a no longer supported legacy IDE otherwise doesn’t know how to handle it.

FlashBuilder is one of many IDEs principally setup to handle FlexJS so if this requires a hack, we should only apply it in case someone uses it.

And I don’t see how this would break things if other IDEs support the “type” element. Then they would just share a hacked SDK, because then the IDE would treat it as “flexjs” SDK with a version 4.8.0.8.0 instead of 0.8.0 … no big deal.

Chris


Am 25.01.17, 16:31 schrieb "Alex Harui" <ah...@adobe.com>:

    I'm not sure I understand.  Are you saying folks would have to designate
    that they are installing an SDK only for use in FB?  Why couldn't they
    share an SDK between IDEs?
    
    -Alex
    
    On 1/25/17, 7:24 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
    
    >Hi Alex,
    >
    >Yeah … I know we are hacking this, but I would like to change this to use
    >the 0.8.0 as a default and to add a build configuration “apply
    >flashbuilder hacks” to make it output a 4.8.0.8.0. Because I otherwise I
    >fear that more and more tool vendors will rely on this hack and make us
    >have to live with it for the next years. I would like to make the
    >descriptor contain a version 0.8.0 and add some sort of
    >“<type>flexjs</type>” element to the descriptor to give tool-vendors more
    >information on the type of Flex SDK
    >
    >Chris
    >
    >Am 25.01.17, 16:09 schrieb "Alex Harui" <ah...@adobe.com>:
    >
    >    Not sure I understand.  We are already hacking the <version> to be
    >4.x for
    >    FlashBuilder.
    >    
    >    I would imagine you could add another tag without breaking things.
    >    
    >    -Alex
    >    
    >    On 1/25/17, 7:06 AM, "Christofer Dutz" <ch...@c-ware.de>
    >wrote:
    >    
    >    >Hi,
    >    >
    >    >I’m currently working on fixing FlexJS support in IntelliJ. I just
    >    >encountered a line of code in which the component sets are selected
    >based
    >    >on the version-number (if it’s greater than 4.5). I don’t want to go
    >down
    >    >the path of hacking the version number of flexJS to be something like
    >    >4.8.0.8.0 so I would rather have the version 0.8.0 but a SDK type in
    >the
    >    >descriptor. Unfortunately I don’t know if adding an element to this
    >would
    >    >break things. What other alternatives would we have to provide this
    >    >information?
    >    >
    >    >Chris
    >    
    >    
    >
    
    


Re: [FlexJS] Change flex sdk descriptor?

Posted by Alex Harui <ah...@adobe.com>.
I'm not sure I understand.  Are you saying folks would have to designate
that they are installing an SDK only for use in FB?  Why couldn't they
share an SDK between IDEs?

-Alex

On 1/25/17, 7:24 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Hi Alex,
>
>Yeah … I know we are hacking this, but I would like to change this to use
>the 0.8.0 as a default and to add a build configuration “apply
>flashbuilder hacks” to make it output a 4.8.0.8.0. Because I otherwise I
>fear that more and more tool vendors will rely on this hack and make us
>have to live with it for the next years. I would like to make the
>descriptor contain a version 0.8.0 and add some sort of
>“<type>flexjs</type>” element to the descriptor to give tool-vendors more
>information on the type of Flex SDK
>
>Chris
>
>Am 25.01.17, 16:09 schrieb "Alex Harui" <ah...@adobe.com>:
>
>    Not sure I understand.  We are already hacking the <version> to be
>4.x for
>    FlashBuilder.
>    
>    I would imagine you could add another tag without breaking things.
>    
>    -Alex
>    
>    On 1/25/17, 7:06 AM, "Christofer Dutz" <ch...@c-ware.de>
>wrote:
>    
>    >Hi,
>    >
>    >I’m currently working on fixing FlexJS support in IntelliJ. I just
>    >encountered a line of code in which the component sets are selected
>based
>    >on the version-number (if it’s greater than 4.5). I don’t want to go
>down
>    >the path of hacking the version number of flexJS to be something like
>    >4.8.0.8.0 so I would rather have the version 0.8.0 but a SDK type in
>the
>    >descriptor. Unfortunately I don’t know if adding an element to this
>would
>    >break things. What other alternatives would we have to provide this
>    >information?
>    >
>    >Chris
>    
>    
>


Re: [FlexJS] Change flex sdk descriptor?

Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Alex,

Yeah … I know we are hacking this, but I would like to change this to use the 0.8.0 as a default and to add a build configuration “apply flashbuilder hacks” to make it output a 4.8.0.8.0. Because I otherwise I fear that more and more tool vendors will rely on this hack and make us have to live with it for the next years. I would like to make the descriptor contain a version 0.8.0 and add some sort of “<type>flexjs</type>” element to the descriptor to give tool-vendors more information on the type of Flex SDK

Chris

Am 25.01.17, 16:09 schrieb "Alex Harui" <ah...@adobe.com>:

    Not sure I understand.  We are already hacking the <version> to be 4.x for
    FlashBuilder.
    
    I would imagine you could add another tag without breaking things.
    
    -Alex
    
    On 1/25/17, 7:06 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
    
    >Hi,
    >
    >I’m currently working on fixing FlexJS support in IntelliJ. I just
    >encountered a line of code in which the component sets are selected based
    >on the version-number (if it’s greater than 4.5). I don’t want to go down
    >the path of hacking the version number of flexJS to be something like
    >4.8.0.8.0 so I would rather have the version 0.8.0 but a SDK type in the
    >descriptor. Unfortunately I don’t know if adding an element to this would
    >break things. What other alternatives would we have to provide this
    >information?
    >
    >Chris
    
    


Re: [FlexJS] Change flex sdk descriptor?

Posted by Alex Harui <ah...@adobe.com>.
Not sure I understand.  We are already hacking the <version> to be 4.x for
FlashBuilder.

I would imagine you could add another tag without breaking things.

-Alex

On 1/25/17, 7:06 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Hi,
>
>I’m currently working on fixing FlexJS support in IntelliJ. I just
>encountered a line of code in which the component sets are selected based
>on the version-number (if it’s greater than 4.5). I don’t want to go down
>the path of hacking the version number of flexJS to be something like
>4.8.0.8.0 so I would rather have the version 0.8.0 but a SDK type in the
>descriptor. Unfortunately I don’t know if adding an element to this would
>break things. What other alternatives would we have to provide this
>information?
>
>Chris