[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5013: Make more hints for java available

[GitBox <gi...@apache.org>]

matthiasblaesing commented on code in PR #5013:
URL: https://github.com/apache/netbeans/pull/5013#discussion_r1036322367


##########
java/java.editor/src/org/netbeans/modules/java/editor/options/InlineHintsOptionsPanelController.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.java.editor.options;
+
+import java.beans.PropertyChangeListener;
+import java.beans.PropertyChangeSupport;
+import javax.swing.JComponent;
+import org.netbeans.spi.options.OptionsPanelController;
+import org.openide.util.HelpCtx;
+import org.openide.util.Lookup;
+
+public final class InlineHintsOptionsPanelController extends OptionsPanelController {
+    
+    private InlineHintsPanel panel;
+    
+    private final PropertyChangeSupport pcs = new PropertyChangeSupport(this);
+                    
+    @Override
+    public void update() {
+        panel.load( this );
+    }
+    
+    @Override
+    public void applyChanges() {
+        panel.store();
+    }
+    
+    @Override
+    public void cancel() {
+	// need not do anything special, if no changes have been persisted yet
+    }
+    
+    @Override
+    public boolean isValid() {
+        return true; // Always valid 
+    }
+    
+    @Override
+    public boolean isChanged() {
+	return panel.changed();
+    }
+    
+    @Override
+    public HelpCtx getHelpCtx() {
+	return new HelpCtx("netbeans.optionsDialog.java.inlineHints");

Review Comment:
   It is a copy from the `Controller` in the same directory. Actually your settings might be different. If you look at the changeset on github everything is in line and the same was true on my system (default NetBeans settings). Anyway, I ran the class through the reformatter and it will be updated with spaces.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists