You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by rafaelgarrote <gi...@git.apache.org> on 2015/03/04 18:46:04 UTC

[GitHub] metamodel pull request: Changes in Query and SelectItemParser to u...

GitHub user rafaelgarrote opened a pull request:

    https://github.com/apache/metamodel/pull/7

    Changes in Query and SelectItemParser to use IN and LIKE operartors into lowercase and AVG, MIN, MAX... functions into lowercase

    - Updated findFilterItem method in order to find either upper and lowercase filter operator types in core/src/main/java/org/apache/metamodel/query/Query.java
    
    It fix "IllegalArgumentException: Expression-based filters cannot be manually evaluated" while using like and in operators into lowercase.
    
    - Updated findSelectItem method in order to find either upper and lowercase function types in core/src/main/java/org/apache/metamodel/query/parser/SelectItemParser.java
    
    It fix "org.apache.metamodel.query.parser.QueryParserException: Not capable of parsing SELECT token: ..." while using avg, min, max... functions into lowercase.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rafaelgarrote/metamodel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 78408c077d2f1a41e8a923c2264c63965deedf83
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-04T14:00:58Z

    updated findFilterItem method in order to find either upper and lowercase filter operator types

commit ec6b30bbb6fa6576d9ccf73383b3b537bda9b8a4
Author: Rafael Garrote <rg...@stratio.com>
Date:   2015-03-04T14:23:55Z

    updated findSelectItem method in order to find either upper and lowercase function types

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: Changes in Query and SelectItemParser to u...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/metamodel/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: Changes in Query and SelectItemParser to u...

Posted by rafaelgarrote <gi...@git.apache.org>.

Github user rafaelgarrote commented on the pull request:

    https://github.com/apache/metamodel/pull/7#issuecomment-77903043
  
    Hi Kasper,
    
    I also found the same problem with DISTINCT into lower case. I made some changes to solve it.
    I added some test in org.apache.metamodel.query.parser.QueryParserTest that must fail without changes and pass with changes:
    - testSelectDistinctInLowerCase()
    - testWhereInInLowerCase()
    - testWhereLikeInLowerCase()
    - testSelectMinInLowerCase()
    - testSelectAvgInLowerCase()
    
    Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: Changes in Query and SelectItemParser to u...

Posted by kaspersorensen <gi...@git.apache.org>.

Github user kaspersorensen commented on the pull request:

    https://github.com/apache/metamodel/pull/7#issuecomment-77702998
  
    Hi Rafael,
    
    Thank you for the Pull Request! It's great to receive such a contribution. Can you better document if this was a problem before? Maybe create a unittest that would break without the fix and run with the fix? Reason I ask is that there is no reference to a JIRA issue or anything like that, and I was actually under the impression that our parser was not case sensitive, but maybe I was wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: Changes in Query and SelectItemParser to u...

Posted by kaspersorensen <gi...@git.apache.org>.

Github user kaspersorensen commented on the pull request:

    https://github.com/apache/metamodel/pull/7#issuecomment-77910789
  
    Looks good! I'll merge it in :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---