You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/19 04:48:39 UTC
[GitHub] [incubator-superset] junlincc opened a new issue #12141: [explore]preset previous week time range
junlincc opened a new issue #12141:
URL: https://github.com/apache/incubator-superset/issues/12141
<img width="1180" alt="Screen Shot 2020-12-18 at 8 41 56 PM" src="https://user-images.githubusercontent.com/67837651/102680903-bfce2480-4171-11eb-8b1a-641cffd3dd0f.png">
<img width="543" alt="Screen Shot 2020-12-18 at 8 43 45 PM" src="https://user-images.githubusercontent.com/67837651/102680907-c2c91500-4171-11eb-946d-1f612ca45532.png">
also minor issue, need to set calendar week range from `Sunday to Saturday` instead of `Monday to Sunday `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zhaoyongjie commented on issue #12141: [explore]customize previous calendar week time range
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #12141:
URL: https://github.com/apache/incubator-superset/issues/12141#issuecomment-748421260
This is a problem that can be solved by introducing a config item.
```
# Which is the first day of the week, the default set to 1 or 0
FIRST_DAY_OF_WEEK = [0-6]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zhaoyongjie commented on issue #12141: [explore]customize previous calendar week time range
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on issue #12141:
URL: https://github.com/apache/incubator-superset/issues/12141#issuecomment-748421954
@nytai Since the server is often set to UTC time zone, it may not be easy to detect
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #12141: [explore]preset previous calendar week time range
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #12141:
URL: https://github.com/apache/incubator-superset/issues/12141#issuecomment-748419498
I this this varies by locale, some start the week on Sunday and others on Monday. From [wikipedia](https://en.wikipedia.org/wiki/Week)
>While, for example, the United States, Canada, Brazil, Japan and other countries consider Sunday as the first day of the week, and while the week begins with Saturday in much of the Middle East, the international ISO 8601 standard and most of Europe has Monday as the first day of the week.
It's likely that whatever library is generating this range is following the ISO 8601 standard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #12141: [explore]preset previous calendar week time range
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12141:
URL: https://github.com/apache/incubator-superset/issues/12141#issuecomment-748420618
enhancement request: allow user to customize "calendar week"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #12141: [explore]customize previous calendar week time range
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #12141:
URL: https://github.com/apache/incubator-superset/issues/12141#issuecomment-748420858
We could also try to detect the locale, but empowering the user is probably best for a BI tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org