[jira] Resolved: (VELTOOLS-7) Add the VelocityWriter to the context of the VelocityViewServlet

["Nathan Bubna (JIRA)" <ve...@apache.org>]

     [ http://issues.apache.org/jira/browse/VELTOOLS-7?page=all ]
     
Nathan Bubna resolved VELTOOLS-7:
---------------------------------

    Resolution: Fixed

done, as of http://svn.apache.org/viewcvs?rev=321228&view=rev

> Add the VelocityWriter to the context of the VelocityViewServlet
> ----------------------------------------------------------------
>
>          Key: VELTOOLS-7
>          URL: http://issues.apache.org/jira/browse/VELTOOLS-7
>      Project: VelocityTools
>         Type: Improvement
>     Versions: 1.1
>  Environment: Operating System: All
> Platform: All
>     Reporter: Bill Boland
>     Assignee: Nathan Bubna
>     Priority: Minor
>      Fix For: 1.2

>
> The reason and purpose of this is for performance situations as stated by 
> Nikolaj.Brinch.Joergensen@sdk.sas.com
> Following the recent thread discussion...
> http://www.mail-archive.com/velocity-user@jakarta.apache.org/msg07051.html
> http://www.mail-archive.com/velocity-user@jakarta.apache.org/msg07066.html
> <snip>
> BUT...this shows where an enhancement would be nice to have. If the
> statement in the mergeTemplate() method of:
>  
>             template.merge( context, vw);
> was replaced with:
>                 performMerge( template, context, vm );
> where performMerge was a protected method of VelocityServlet with the
> original statement as its default behavior, then you could easily
> override this method in a subclass of VelocityServlet to place the
> writer into the context. The VelocityServlet could still manage the
> private writerPool.
> <\snip>
> An alternative solution would be to allow the writerPool, encoding and other 
> private methods be protected so that it would be easier to override the 
> mergerTemplate method so this could be implemented by the developer. Maybe both 
> should be done. :)
> bill

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: velocity-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: velocity-dev-help@jakarta.apache.org