You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/11 09:43:56 UTC
[GitHub] [hudi] Zouxxyy opened a new pull request, #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Zouxxyy opened a new pull request, #6652:
URL: https://github.com/apache/hudi/pull/6652
### Change Logs
Fix testNoGlobalConfFileConfigured
### Impact
none
**Risk level: none**
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r972557066
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
let's not create DFSPropertiesConfiguration again to generate the expected value. we should just load the default hudi-defaults.conf with plain java properties and get the count as the expected size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1255847512
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297)
* 5492efb3e9091fcd1c0c3d58189ad292381df96c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1255958072
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297)
* 5492efb3e9091fcd1c0c3d58189ad292381df96c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614)
* 645096cfd9428f2725efc258a7559b52b762b3f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1242934632
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #6652:
URL: https://github.com/apache/hudi/pull/6652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1257244570
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
}, {
"hash" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11714",
"triggerID" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1389d15e3a8c65fba779385700ef70df0ad5401c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11714)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r974264887
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
@Zouxxyy then we need a different way to load the default conf file and set it as the expected value. the current way is not the right way for testing: both expected and tested use `DFSPropertiesConfiguration` to load. what if there is a bug with `DFSPropertiesConfiguration` loading conf file and both return unexpected numbers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1242933903
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r969225078
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
The test will fail when`/etc/hudi/conf/hudi-defaults.conf` exists locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1242957177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1255956083
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1256490282
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 645096cfd9428f2725efc258a7559b52b762b3f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1257360490
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r972869009
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
> so the logic should be count the configs from hudi-defaults.conf at the default path if exists, or make it 0 if not exists. @Zouxxyy can you make change for this please? then we should be good to land
hudi uses it's own method to read props instead of Apache commons PropertiesConfiguration, just like this
```java
public void addPropsFromStream(BufferedReader reader) throws IOException {
try {
reader.lines().forEach(line -> {
if (!isValidLine(line)) {
return;
}
String[] split = splitProperty(line);
if (line.startsWith("include=") || line.startsWith("include =")) {
Path includeFilePath = new Path(currentFilePath.getParent(), split[1]);
addPropsFromFile(includeFilePath);
} else {
hoodieConfig.setValue(split[0], split[1]);
}
});
} finally {
reader.close();
}
}
```
currently there is no static method to get prop directly from a path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r978306628
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
> @Zouxxyy then we need a different way to load the default conf file and set it as the expected value. the current way is not the right way for testing: both expected and tested use `DFSPropertiesConfiguration` to load. what if there is a bug with `DFSPropertiesConfiguration` loading conf file and both return unexpected numbers, the test would still pass but not catching bug
I made some modifications.
I think this test case is only used to test the effect of clearing env HUDI_CONF_DIR, so the test can be ignored when hudi-defaults.conf exists locally.
And if you want to test loading hudi-defaults.conf, it should be covered by other tests, such as testParsing, testLoadGlobalConfFile, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1255963652
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297)
* 5492efb3e9091fcd1c0c3d58189ad292381df96c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614)
* 645096cfd9428f2725efc258a7559b52b762b3f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r972557608
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
so the logic should be count the configs from hudi-defaults.conf at the default path if exists, or make it 0 if not exists. @Zouxxyy can you make change for this please? then we should be good to land
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1256340583
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5492efb3e9091fcd1c0c3d58189ad292381df96c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614)
* 645096cfd9428f2725efc258a7559b52b762b3f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1257360848
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
}, {
"hash" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11714",
"triggerID" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"triggerType" : "PUSH"
}, {
"hash" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11718",
"triggerID" : "1257360490",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1389d15e3a8c65fba779385700ef70df0ad5401c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11714) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11718)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1257219456
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
}, {
"hash" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 645096cfd9428f2725efc258a7559b52b762b3f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616)
* 1389d15e3a8c65fba779385700ef70df0ad5401c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1255893977
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297)
* 5492efb3e9091fcd1c0c3d58189ad292381df96c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614)
* 645096cfd9428f2725efc258a7559b52b762b3f9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1257437360
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
}, {
"hash" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11714",
"triggerID" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"triggerType" : "PUSH"
}, {
"hash" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11718",
"triggerID" : "1257360490",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 1389d15e3a8c65fba779385700ef70df0ad5401c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11714) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11718)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1257220303
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255956083",
"triggerType" : "MANUAL"
}, {
"hash" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11714",
"triggerID" : "1389d15e3a8c65fba779385700ef70df0ad5401c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 645096cfd9428f2725efc258a7559b52b762b3f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616)
* 1389d15e3a8c65fba779385700ef70df0ad5401c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11714)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r969225078
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
`DFSPropertiesConfiguration.refreshGlobalProps()` only refresh the system props, and the test will fail when`/etc/hudi/conf/hudi-defaults.conf` exists locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
yihua commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r969215352
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
Is this test broken in CI? I could not reproduce the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1255898376
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616",
"triggerID" : "1255877329",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297)
* 5492efb3e9091fcd1c0c3d58189ad292381df96c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614)
* 645096cfd9428f2725efc258a7559b52b762b3f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11616)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1255850711
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297",
"triggerID" : "3b4a114aa334d11d59c5e348f47736084ebc4b57",
"triggerType" : "PUSH"
}, {
"hash" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614",
"triggerID" : "5492efb3e9091fcd1c0c3d58189ad292381df96c",
"triggerType" : "PUSH"
}, {
"hash" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "645096cfd9428f2725efc258a7559b52b762b3f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3b4a114aa334d11d59c5e348f47736084ebc4b57 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11297)
* 5492efb3e9091fcd1c0c3d58189ad292381df96c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11614)
* 645096cfd9428f2725efc258a7559b52b762b3f9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on PR #6652:
URL: https://github.com/apache/hudi/pull/6652#issuecomment-1255877329
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6652: [HUDI-4830] Fix testNoGlobalConfFileConfigured when add hudi-defaults.conf in default dir
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6652:
URL: https://github.com/apache/hudi/pull/6652#discussion_r974264887
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestDFSPropertiesConfiguration.java:
##########
@@ -173,7 +173,9 @@ public void testNoGlobalConfFileConfigured() {
ENVIRONMENT_VARIABLES.clear(DFSPropertiesConfiguration.CONF_FILE_DIR_ENV_NAME);
// Should not throw any exception when no external configuration file configured
DFSPropertiesConfiguration.refreshGlobalProps();
- assertEquals(0, DFSPropertiesConfiguration.getGlobalProps().size());
+ DFSPropertiesConfiguration defaultDfsPropertiesConfiguration = new DFSPropertiesConfiguration();
+ defaultDfsPropertiesConfiguration.addPropsFromFile(DFSPropertiesConfiguration.DEFAULT_PATH);
+ assertEquals(defaultDfsPropertiesConfiguration.getProps().size(), DFSPropertiesConfiguration.getGlobalProps().size());
Review Comment:
@Zouxxyy then we need a different way to load the default conf file and set it as the expected value. the current way is not the right way for testing: both expected and tested use `DFSPropertiesConfiguration` to load. what if there is a bug with `DFSPropertiesConfiguration` loading conf file and both return unexpected numbers, the test would still pass but not catching bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org