You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Skye Wanderman-Milne (Code Review)" <ge...@cloudera.org> on 2016/04/11 23:41:43 UTC

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

Skye Wanderman-Milne has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2758

Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()
......................................................................

IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

This patch implements codegen for (part of) the BuildHashTable()
function by codegening a version of the new InsertBatch() function,
which is called by BuildHashTableInternal(). The codegen'd
InsertBatch() is based on the cross-compiled original, and replaces
EvalBuildRow(), Equals(), and HashCurrentRow() calls.

For the following benchmark query:
 SELECT STRAIGHT_JOIN count(*)
 FROM tpch_parquet.orders l1
 JOIN [broadcast] biglineitem ON l_orderkey = o_orderkey
 WHERE l_partkey > 0
 AND l_suppkey > 0
 AND l_linenumber > 0
 AND o_orderdate < '19000'
 AND l_orderkey < 350000000;

Hash table build time went from 7.4s to 3.7s (2x faster), and overall
query time went from 18.1s to 14.1s (28% faster). This increased
codegen time from 212ms to 279ms (30% slower).

This patch also changes the BUILD_RUNTIME_FILTERS conditional to be
based on an input argument rather than a template parameter. This
slightly slows down execution but as the benefit of requiring fewer
codegen'd functions.

Change-Id: I616f46a861b4909d7a6e66dcf947b3518556768e

remove template param

Change-Id: I519425d73f390ee95e0cc25923132fdbe308ca1c
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/partitioned-hash-join-node-ir.cc
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/partitioned-hash-join-node.h
4 files changed, 139 insertions(+), 38 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/58/2758/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I519425d73f390ee95e0cc25923132fdbe308ca1c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <sk...@cloudera.com>