You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nemo.apache.org by gw...@apache.org on 2020/06/26 08:16:59 UTC

[incubator-nemo] branch master updated: [MINOR] Fix Travis CI + Bring back support for Java 8 (#296)

This is an automated email from the ASF dual-hosted git repository.

gwlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nemo.git


The following commit(s) were added to refs/heads/master by this push:
     new 24b246d  [MINOR] Fix Travis CI + Bring back support for Java 8 (#296)
24b246d is described below

commit 24b246dc18d3455a3e46fc8163711eb485b06316
Author: Won Wook SONG <wo...@apache.org>
AuthorDate: Fri Jun 26 17:16:53 2020 +0900

    [MINOR] Fix Travis CI + Bring back support for Java 8 (#296)
    
    **Major changes:**
    - Fixes Travis CI script that have been failing due to gpg error
    - Bring back support for Java 8, as Hadoop and REEF still needs support for Java 8 (reverts #291)
    
    **Minor changes to note:**
    - None
    
    **Tests for the changes:**
    - N/A
    
    **Other comments:**
    - None
    
    Closes #296
---
 .travis.yml | 2 +-
 README.md   | 2 +-
 pom.xml     | 9 +++++----
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 84248c4..477eb1c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -22,6 +22,7 @@ dist: trusty
 # For maven builds
 language: java
 jdk:
+  - oraclejdk8
   - oraclejdk11
   - openjdk11
 env:
@@ -30,7 +31,6 @@ env:
   jobs:
     - GOAL="verify -B -q -ff -Dsurefire.useFile=false -Dorg.slf4j.simpleLogger.defaultLogLevel=info"
 before_install:
-  - sudo apt update && sudo apt install -y libgif-dev
   - nvm install node  # for Web UI build
 install: true
 script:
diff --git a/README.md b/README.md
index 4ba0298..d92bbcd 100644
--- a/README.md
+++ b/README.md
@@ -17,7 +17,7 @@ Please refer to the [Contribution guideline](.github/CONTRIBUTING.md) to contrib
 ## Nemo prerequisites and setup
 
 ### Prerequisites
-* Java 11
+* Java 8 or later (tested on Java 8 and Java 11)
 * Maven
 * YARN settings
     * Download Hadoop 2.7.2 at https://archive.apache.org/dist/hadoop/common/hadoop-2.7.2/
diff --git a/pom.xml b/pom.xml
index 5a5297c..66e14fe 100644
--- a/pom.xml
+++ b/pom.xml
@@ -41,7 +41,7 @@ under the License.
   </scm>
 
   <properties>
-    <java.version>11</java.version>
+    <java.version>1.8</java.version>
     <maven.compiler.source>${java.version}</maven.compiler.source>
     <maven.compiler.target>${java.version}</maven.compiler.target>
     <maven.compiler.version>3.8.1</maven.compiler.version>
@@ -176,9 +176,10 @@ under the License.
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-compiler-plugin</artifactId>
           <version>${maven.compiler.version}</version>
-          <configuration>
-            <release>${java.version}</release>
-          </configuration>
+          <!-- Uncomment when dropping support for Java 8 -->
+          <!--<configuration>-->
+          <!--  <release>${java.version}</release>-->
+          <!--</configuration>-->
         </plugin>
         <plugin>
           <groupId>org.codehaus.mojo</groupId>