You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/09/22 05:07:16 UTC
Review Request 38602: Fixed minor typo in Executor API protobuf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38602/
-----------------------------------------------------------
Review request for mesos, Isabel Jimenez and Vinod Kone.
Repository: mesos
Description
-------
Trivial change to fix a typo in the 'subscribed' field in protobuf.
Diffs
-----
include/mesos/executor/executor.proto 34bddc4ae7898a32233dc1bbef9d8453705346b6
include/mesos/v1/executor/executor.proto 3f63d30687c8fe71a870eb62cb97f2c538c66ab1
Diff: https://reviews.apache.org/r/38602/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 38602: Fixed minor typo in Executor API protobuf
Posted by Jian Qiu <qi...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38602/#review99952
-----------------------------------------------------------
Ship it!
Ship It!
- Jian Qiu
On Sept. 22, 2015, 3:07 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38602/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 3:07 a.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to fix a typo in the 'subscribed' field in protobuf.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 34bddc4ae7898a32233dc1bbef9d8453705346b6
> include/mesos/v1/executor/executor.proto 3f63d30687c8fe71a870eb62cb97f2c538c66ab1
>
> Diff: https://reviews.apache.org/r/38602/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38602: Fixed minor typo in Executor API protobuf
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38602/#review99913
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 九月 22, 2015, 3:07 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38602/
> -----------------------------------------------------------
>
> (Updated 九月 22, 2015, 3:07 a.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to fix a typo in the 'subscribed' field in protobuf.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 34bddc4ae7898a32233dc1bbef9d8453705346b6
> include/mesos/v1/executor/executor.proto 3f63d30687c8fe71a870eb62cb97f2c538c66ab1
>
> Diff: https://reviews.apache.org/r/38602/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38602: Fixed minor typo in Executor API protobuf
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38602/#review99947
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38602]
All tests passed.
- Mesos ReviewBot
On Sept. 22, 2015, 3:07 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38602/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 3:07 a.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to fix a typo in the 'subscribed' field in protobuf.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 34bddc4ae7898a32233dc1bbef9d8453705346b6
> include/mesos/v1/executor/executor.proto 3f63d30687c8fe71a870eb62cb97f2c538c66ab1
>
> Diff: https://reviews.apache.org/r/38602/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38602: Fixed minor typo in Executor API protobuf
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38602/#review99950
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Sept. 22, 2015, 3:07 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38602/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 3:07 a.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to fix a typo in the 'subscribed' field in protobuf.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 34bddc4ae7898a32233dc1bbef9d8453705346b6
> include/mesos/v1/executor/executor.proto 3f63d30687c8fe71a870eb62cb97f2c538c66ab1
>
> Diff: https://reviews.apache.org/r/38602/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38602: Fixed minor typo in Executor API protobuf
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38602/#review100212
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 22, 2015, 3:07 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38602/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 3:07 a.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to fix a typo in the 'subscribed' field in protobuf.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto 34bddc4ae7898a32233dc1bbef9d8453705346b6
> include/mesos/v1/executor/executor.proto 3f63d30687c8fe71a870eb62cb97f2c538c66ab1
>
> Diff: https://reviews.apache.org/r/38602/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>