You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2021/02/16 18:56:00 UTC
[jira] [Commented] (TIKA-3301) Simplify forking/monitoring in
tika-server for 2.x
[ https://issues.apache.org/jira/browse/TIKA-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285422#comment-17285422 ]
Hudson commented on TIKA-3301:
------------------------------
SUCCESS: Integrated in Jenkins build Tika ยป tika-main-jdk8 #162 (See [https://ci-builds.apache.org/job/Tika/job/tika-main-jdk8/162/])
TIKA-3301 -- simplify forking and monitoring in tika-server (tallison: [https://github.com/apache/tika/commit/28be37e68db8c5b749ed08b4b14d02b14b24c9f6])
* (edit) tika-server/tika-server-core/src/main/java/org/apache/tika/server/core/TikaServerCli.java
* (edit) tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/TikaServerAsyncIntegrationTest.java
* (edit) tika-server/tika-server-core/src/main/java/org/apache/tika/server/core/ServerStatusWatcher.java
* (edit) tika-server/tika-server-core/src/test/resources/configs/tika-config-server.xml
* (edit) tika-server/tika-server-core/src/main/java/org/apache/tika/server/core/TikaServerProcess.java
* (edit) tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/TikaServerIntegrationTest.java
* (edit) tika-server/tika-server-core/src/main/java/org/apache/tika/server/core/TikaServerWatchDog.java
* (edit) tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/TikaServerEmitterIntegrationTest.java
* (edit) tika-server/tika-server-core/src/main/java/org/apache/tika/server/core/TikaServerConfig.java
* (edit) tika-server/tika-server-core/src/test/resources/configs/tika-config-server-timeout-10000.xml
* (edit) tika-server/tika-server-core/src/test/java/org/apache/tika/server/core/IntegrationTestBase.java
* (edit) tika-server/tika-server-core/src/test/resources/configs/tika-config-server-emitter.xml
> Simplify forking/monitoring in tika-server for 2.x
> --------------------------------------------------
>
> Key: TIKA-3301
> URL: https://issues.apache.org/jira/browse/TIKA-3301
> Project: Tika
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Minor
> Fix For: 2.0.0
>
>
> In looking back at the code for tika-server's forking process and monitoring. We can simplify it quite a bit and make restarts more timely and efficient.
> We should change a few Thread.sleep calls to process.waitFor() so that we're notified instantly if a forked process dies.
> We don't need the pinging communication via stdout/stdin between forking and forked. The forking process can monitor the forked process via the forkedstatusfile and watching for an exit value on the process. The forked process can monitor its parent by blocking on a read of stdin.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)