You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "baihui (GitHub)" <gi...@apache.org> on 2018/09/26 22:40:13 UTC
[GitHub] [incubator-dubbo] baihui opened pull request #2566: Update
AbstractRegistryFactory.java
减少锁颗粒
在获取注册服务 时候只阻塞未创建过相同的key的线程
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2566 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang closed pull request #2566:
Update AbstractRegistryFactory.java
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
[ pull request closed by zonghaishang ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2566 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2566:
Update AbstractRegistryFactory.java
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
1.use English
2. use doc like this: // doc... don't forget the space.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2566 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2566:
Update AbstractRegistryFactory.java
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2566?src=pr&el=h1) Report
> Merging [#2566](https://codecov.io/gh/apache/incubator-dubbo/pull/2566?src=pr&el=desc) into [3.x-dev](https://codecov.io/gh/apache/incubator-dubbo/commit/755bbf92741d4fcfed52bf314a5971a53c46b00c?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2566?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 3.x-dev #2566 +/- ##
=============================================
- Coverage 54.96% 54.89% -0.08%
+ Complexity 5278 5273 -5
=============================================
Files 573 573
Lines 25517 25517
Branches 4531 4532 +1
=============================================
- Hits 14026 14008 -18
- Misses 9390 9403 +13
- Partials 2101 2106 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2566?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ubbo/registry/support/AbstractRegistryFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2566/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnlGYWN0b3J5LmphdmE=) | `48.38% <66.66%> (-3.23%)` | `4 <0> (ø)` | |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2566/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `40% <0%> (-36%)` | `6% <0%> (-1%)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2566/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `75.86% <0%> (-10.35%)` | `11% <0%> (ø)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2566/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `54.21% <0%> (-3.62%)` | `13% <0%> (-2%)` | |
| [...ache/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2566/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNsaWVudC5qYXZh) | `56.92% <0%> (-1.54%)` | `8% <0%> (-1%)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2566/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `61.17% <0%> (-1.18%)` | `22% <0%> (-1%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2566?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2566?src=pr&el=footer). Last update [755bbf9...0d85d88](https://codecov.io/gh/apache/incubator-dubbo/pull/2566?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2566 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zonghaishang commented on pull request
#2566: Update AbstractRegistryFactory.java
Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
Locking here is not correct.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2566 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on pull request #2566:
Update AbstractRegistryFactory.java
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
remove unnecessary enter
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2566 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org