You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/06/29 13:27:57 UTC
[GitHub] [arrow] thisisnic opened a new pull request, #36381: GH-36380: [R] Create convenience function arrow_array
thisisnic opened a new pull request, #36381:
URL: https://github.com/apache/arrow/pull/36381
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a diff in pull request #36381: GH-36380: [R] Create convenience function arrow_array
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on code in PR #36381:
URL: https://github.com/apache/arrow/pull/36381#discussion_r1246873880
##########
r/R/array.R:
##########
@@ -549,3 +548,17 @@ MapArray <- R6Class("MapArray",
items_nested = function() MapArray__items_nested(self)
)
)
+
+#' Create an Arrow Array
+#'
+#' @param x An R vector, list, or `data.frame`
Review Comment:
Great suggestion, have incorporated, cheers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on a diff in pull request #36381: GH-36380: [R] Create convenience function arrow_array
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #36381:
URL: https://github.com/apache/arrow/pull/36381#discussion_r1246864415
##########
r/R/array.R:
##########
@@ -549,3 +548,17 @@ MapArray <- R6Class("MapArray",
items_nested = function() MapArray__items_nested(self)
)
)
+
+#' Create an Arrow Array
+#'
+#' @param x An R vector, list, or `data.frame`
Review Comment:
Maybe "An R object representable as an Arrow array"? Or some combination of that and what's here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36381: GH-36380: [R] Create convenience function arrow_array
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36381:
URL: https://github.com/apache/arrow/pull/36381#issuecomment-1613189840
Revision: 8f6febda98adf04d8a144757c247d724ce9bb3d6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-efac4c7277](https://github.com/ursacomputing/crossbow/branches/all?query=actions-efac4c7277)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/5412799747/jobs/9837408810)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic merged pull request #36381: GH-36380: [R] Create convenience function arrow_array
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic merged PR #36381:
URL: https://github.com/apache/arrow/pull/36381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #36381: GH-36380: [R] Create convenience function arrow_array
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #36381:
URL: https://github.com/apache/arrow/pull/36381#issuecomment-1613185835
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on pull request #36381: GH-36380: [R] Create convenience function arrow_array
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #36381:
URL: https://github.com/apache/arrow/pull/36381#issuecomment-1613479600
Preview is here: http://crossbow.voltrondata.com/pr_docs/36381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36381: GH-36380: [R] Create convenience function arrow_array
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36381:
URL: https://github.com/apache/arrow/pull/36381#issuecomment-1621050020
Conbench analyzed the 6 benchmark runs on commit `3fa7d603`.
There were 5 benchmark results indicating a performance regression:
- Commit Run on `arm64-m6g-linux-compute` at [2023-06-29 19:48:20Z](http://conbench.ursa.dev/compare/runs/d9dd5d633ee9475495a6528c5a9dfc14...61dc5fa92570411083bb6a8a3864393c/)
- [params=<UInt64Type>, source=cpp-micro, suite=arrow-value-parsing-benchmark](http://conbench.ursa.dev/compare/benchmarks/0649dca6dd6a7cbd80002709fbb07e19...0649de03dd617f76800028923277446e)
- Commit Run on `ursa-i9-9960x` at [2023-07-05 02:39:20Z](http://conbench.ursa.dev/compare/runs/db728d6e6827467892465ac8c54649d2...d5ea991070fd434d93dc20fc3bf8b300/)
- [engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-01, scale_factor=1](http://conbench.ursa.dev/compare/benchmarks/064a4c04b78c70b68000277e8901ac22...064a4f0978f579a880003ab13c8cfb22)
- and 3 more (see the report linked below)
The [full Conbench report](https://github.com/apache/arrow/runs/14783228662) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org