You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jiangjie Qin <be...@gmail.com> on 2015/01/20 19:51:44 UTC
Review Request 30083: Patch for KAFKA-1839
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30083/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1839
https://issues.apache.org/jira/browse/KAFKA-1839
Repository: kafka
Description
-------
Modified unit test.
Diffs
-----
core/src/main/scala/kafka/consumer/PartitionAssignor.scala e6ff7683a0df4a7d221e949767e57c34703d5aad
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 191a8677444e53b043e9ad6e94c5a9191c32599e
core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java facf509841918bdcf92a271d29f6c825ff99345a
core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249
core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala 24954de66ccc5158696166b7e2aabad0f1b1f287
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020
Diff: https://reviews.apache.org/r/30083/diff/
Testing
-------
Thanks,
Jiangjie Qin
Re: Review Request 30083: Patch for KAFKA-1839
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30083/#review71133
-----------------------------------------------------------
Ship it!
core/src/main/scala/kafka/consumer/PartitionAssignor.scala
<https://reviews.apache.org/r/30083/#comment116763>
Copy the comment as in RangeAssignor here.
- Guozhang Wang
On Jan. 20, 2015, 9:28 p.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30083/
> -----------------------------------------------------------
>
> (Updated Jan. 20, 2015, 9:28 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1839
> https://issues.apache.org/jira/browse/KAFKA-1839
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Modified unit test.
>
>
> Minor code change
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/consumer/PartitionAssignor.scala e6ff7683a0df4a7d221e949767e57c34703d5aad
> core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 191a8677444e53b043e9ad6e94c5a9191c32599e
> core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java facf509841918bdcf92a271d29f6c825ff99345a
> core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249
> core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala 24954de66ccc5158696166b7e2aabad0f1b1f287
> core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020
>
> Diff: https://reviews.apache.org/r/30083/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
Re: Review Request 30083: Patch for KAFKA-1839
Posted by Jiangjie Qin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30083/
-----------------------------------------------------------
(Updated Jan. 20, 2015, 9:28 p.m.)
Review request for kafka.
Bugs: KAFKA-1839
https://issues.apache.org/jira/browse/KAFKA-1839
Repository: kafka
Description (updated)
-------
Modified unit test.
Minor code change
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/PartitionAssignor.scala e6ff7683a0df4a7d221e949767e57c34703d5aad
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 191a8677444e53b043e9ad6e94c5a9191c32599e
core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java facf509841918bdcf92a271d29f6c825ff99345a
core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249
core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala 24954de66ccc5158696166b7e2aabad0f1b1f287
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020
Diff: https://reviews.apache.org/r/30083/diff/
Testing
-------
Thanks,
Jiangjie Qin
Re: Review Request 30083: Patch for KAFKA-1839
Posted by Jiangjie Qin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30083/
-----------------------------------------------------------
(Updated Jan. 20, 2015, 7:49 p.m.)
Review request for kafka.
Bugs: KAFKA-1839
https://issues.apache.org/jira/browse/KAFKA-1839
Repository: kafka
Description (updated)
-------
Modified unit test.
Diffs (updated)
-----
core/src/main/scala/kafka/consumer/PartitionAssignor.scala e6ff7683a0df4a7d221e949767e57c34703d5aad
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 191a8677444e53b043e9ad6e94c5a9191c32599e
core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java facf509841918bdcf92a271d29f6c825ff99345a
core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249
core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala 24954de66ccc5158696166b7e2aabad0f1b1f287
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020
Diff: https://reviews.apache.org/r/30083/diff/
Testing
-------
Thanks,
Jiangjie Qin
Re: Review Request 30083: Patch for KAFKA-1839
Posted by Jiangjie Qin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30083/
-----------------------------------------------------------
(Updated Jan. 20, 2015, 6:54 p.m.)
Review request for kafka.
Bugs: KAFKA-1839
https://issues.apache.org/jira/browse/KAFKA-1839
Repository: kafka
Description (updated)
-------
Added a beforeStartingFetchers hook to consumer rebalance listener.
Modified unit test.
Diffs
-----
core/src/main/scala/kafka/consumer/PartitionAssignor.scala e6ff7683a0df4a7d221e949767e57c34703d5aad
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala 191a8677444e53b043e9ad6e94c5a9191c32599e
core/src/main/scala/kafka/javaapi/consumer/ConsumerRebalanceListener.java facf509841918bdcf92a271d29f6c825ff99345a
core/src/main/scala/kafka/tools/MirrorMaker.scala 5cbc8103e33a0a234d158c048e5314e841da6249
core/src/test/scala/unit/kafka/consumer/PartitionAssignorTest.scala 24954de66ccc5158696166b7e2aabad0f1b1f287
core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala a17e8532c44aadf84b8da3a57bcc797a848b5020
Diff: https://reviews.apache.org/r/30083/diff/
Testing
-------
Thanks,
Jiangjie Qin