[GitHub] [ignite-3] Berkof commented on a change in pull request #452: IGNITE-15785 POJO validation.

[GitBox <gi...@apache.org>]

Berkof commented on a change in pull request #452:
URL: https://github.com/apache/ignite-3/pull/452#discussion_r753946000



##########
File path: modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java
##########
@@ -96,16 +99,16 @@ public Column(
      * @param name        Column name.
      * @param type        An instance of column data type.
      * @param nullable    If {@code false}, null values will not be allowed for this column.
-     * @param defValSup   Default value supplier.
+     * @param defValSup   Default value supplier or {@code null} - if there is no default value supplier specified.
      */
     public Column(
             int columnOrder,
             String name,
             NativeType type,
             boolean nullable,
-            @NotNull Supplier<Object> defValSup
+            Supplier<Object> defValSup

Review comment:
       Remove from second public constructor. They will replace null with static null supplier and behaviour will be equal to SQL, where "default null" (like "() -> null" in Java) do nothing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org