You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/05/15 00:05:53 UTC

[Impala-ASF-CR] IMPALA-12096: Add process start time and version to backends webui

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19800 )

Change subject: IMPALA-12096: Add process start time and version to backends webui
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19800/2/common/protobuf/statestore_service.proto
File common/protobuf/statestore_service.proto:

http://gerrit.cloudera.org:8080/#/c/19800/2/common/protobuf/statestore_service.proto@80
PS2, Line 80:   optional string process_start_time = 13;
nit: please add comments as we did for other fields. Also mention this is a pretty-printed string.



-- 
To view, visit http://gerrit.cloudera.org:8080/19800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f1f0ba0081986f428840442c247d7dde9e1ba05
Gerrit-Change-Number: 19800
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 15 May 2023 00:05:53 +0000
Gerrit-HasComments: Yes