You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/08/18 00:41:32 UTC
[GitHub] [phoenix] yanxinyi opened a new pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
yanxinyi opened a new pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288
…efully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] nsgupta1 commented on a change in pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
nsgupta1 commented on a change in pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#discussion_r692414234
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -666,8 +681,8 @@ public void clearTableRegionCache(byte[] tableName) throws SQLException {
do {
HRegionLocation regionLocation = connection.getRegionLocation(
TableName.valueOf(tableName), currentKey, reload);
Review comment:
@yanxinyi @dbwong are the locations in the regionLocations object always sorted ? If yes, then only it makes sense to compare if previous endKey is lesser than current endKey otherwise just comparing for equality will give us an answer if it is overlap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#issuecomment-901622997
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 58s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 20s | 4.x passed |
| +1 :green_heart: | compile | 1m 10s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 14s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 48s | 4.x passed |
| +0 :ok: | spotbugs | 3m 22s | phoenix-core in 4.x has 958 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 37s | the patch passed |
| +1 :green_heart: | compile | 1m 7s | the patch passed |
| +1 :green_heart: | javac | 1m 7s | the patch passed |
| -1 :x: | checkstyle | 1m 14s | phoenix-core: The patch generated 8 new + 1061 unchanged - 3 fixed = 1069 total (was 1064) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 32s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 200m 5s | phoenix-core in the patch passed. |
| +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. |
| | | 247m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1288 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 56b71e42a22f 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 9dc5e2e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/4/artifact/yetus-general-check/output/whitespace-eol.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/4/testReport/ |
| Max. process+thread count | 5293 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/4/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] dbwong commented on a change in pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
dbwong commented on a change in pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#discussion_r691497275
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/query/ConnectionQueryServicesImplTest.java
##########
@@ -157,6 +159,49 @@ public void testExceptionHandlingOnSystemNamespaceCreation() throws Exception {
}
}
Review comment:
Maybe one more test for the start/end keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#issuecomment-900760630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on a change in pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#discussion_r692497142
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -666,8 +681,8 @@ public void clearTableRegionCache(byte[] tableName) throws SQLException {
do {
HRegionLocation regionLocation = connection.getRegionLocation(
TableName.valueOf(tableName), currentKey, reload);
Review comment:
yes, this is the reason that we need to make sure the end key always increasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#issuecomment-902249943
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 19s | 4.x passed |
| +1 :green_heart: | compile | 1m 6s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 14s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 49s | 4.x passed |
| +0 :ok: | spotbugs | 3m 26s | phoenix-core in 4.x has 958 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 53s | the patch passed |
| +1 :green_heart: | compile | 1m 8s | the patch passed |
| +1 :green_heart: | javac | 1m 8s | the patch passed |
| -1 :x: | checkstyle | 1m 13s | phoenix-core: The patch generated 8 new + 1061 unchanged - 3 fixed = 1069 total (was 1064) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 41s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 235m 21s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 39s | The patch does not generate ASF License warnings. |
| | | 285m 25s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.index.ImmutableIndexExtendedIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1288 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 68a8bf1fd0d1 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 9dc5e2e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/6/artifact/yetus-general-check/output/whitespace-eol.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/6/testReport/ |
| Max. process+thread count | 4914 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/6/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#issuecomment-901768171
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 4s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 13s | 4.x passed |
| +1 :green_heart: | compile | 1m 9s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 13s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 48s | 4.x passed |
| +0 :ok: | spotbugs | 3m 19s | phoenix-core in 4.x has 958 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 50s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 1m 14s | phoenix-core: The patch generated 5 new + 1064 unchanged - 0 fixed = 1069 total (was 1064) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 34s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 200m 32s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 39s | The patch does not generate ASF License warnings. |
| | | 249m 59s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.AuditLoggingIT |
| | phoenix.end2end.index.PartialIndexRebuilderIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1288 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 8ade9dc8511e 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 9dc5e2e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/5/artifact/yetus-general-check/output/whitespace-eol.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/5/testReport/ |
| Max. process+thread count | 5226 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/5/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#issuecomment-900760630
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 46s | 4.x passed |
| +1 :green_heart: | compile | 1m 9s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 21s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 54s | 4.x passed |
| +0 :ok: | spotbugs | 3m 42s | phoenix-core in 4.x has 958 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 12m 3s | the patch passed |
| +1 :green_heart: | compile | 1m 12s | the patch passed |
| +1 :green_heart: | javac | 1m 12s | the patch passed |
| -1 :x: | checkstyle | 1m 17s | phoenix-core: The patch generated 4 new + 1064 unchanged - 0 fixed = 1068 total (was 1064) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 50s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 49s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 45m 42s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. |
| | | 96m 26s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.OrderByWithSpillingIT |
| | phoenix.end2end.KeyOnlyIT |
| | phoenix.end2end.LnLogFunctionEnd2EndIT |
| | phoenix.end2end.DistinctPrefixFilterIT |
| | phoenix.end2end.ToNumberFunctionIT |
| | phoenix.end2end.MinMaxAggregateFunctionIT |
| | phoenix.end2end.ConnectionUtilIT |
| | phoenix.end2end.index.SaltedIndexIT |
| | phoenix.end2end.PointInTimeScanQueryIT |
| | phoenix.rpc.UpdateCacheIT |
| | phoenix.end2end.StatementHintsIT |
| | phoenix.end2end.index.IndexCoprocIT |
| | phoenix.end2end.DateArithmeticIT |
| | phoenix.end2end.DecodeFunctionIT |
| | phoenix.end2end.StddevIT |
| | phoenix.end2end.join.SortMergeJoinNoSpoolingIT |
| | phoenix.end2end.NullIT |
| | phoenix.end2end.WALAnnotationIT |
| | phoenix.iterate.RoundRobinResultIteratorIT |
| | phoenix.end2end.ShowCreateTableIT |
| | phoenix.iterate.ScannerLeaseRenewalIT |
| | phoenix.end2end.GroupByIT |
| | phoenix.end2end.UnionAllIT |
| | phoenix.end2end.IndexToolForDeleteBeforeRebuildIT |
| | phoenix.end2end.AlterSessionIT |
| | phoenix.end2end.index.PartialIndexRebuilderIT |
| | phoenix.end2end.ReverseScanIT |
| | phoenix.end2end.ContextClassloaderIT |
| | phoenix.end2end.PercentileIT |
| | phoenix.end2end.IndexRebuildTaskIT |
| | phoenix.tx.ParameterizedTransactionIT |
| | phoenix.end2end.MappingTableDataTypeIT |
| | phoenix.end2end.IndexToolForPartialBuildIT |
| | phoenix.end2end.ArrayToStringFunctionIT |
| | phoenix.end2end.ToCharFunctionIT |
| | phoenix.monitoring.PhoenixLoggingMetricsIT |
| | phoenix.end2end.ReadIsolationLevelIT |
| | phoenix.end2end.UpgradeIT |
| | phoenix.util.IndexScrutinyIT |
| | phoenix.end2end.OrderByIT |
| | phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT |
| | phoenix.end2end.ImmutableTableIT |
| | phoenix.end2end.index.MutableIndexIT |
| | phoenix.end2end.ClientHashAggregateIT |
| | phoenix.end2end.MergeViewIndexIdSequencesToolIT |
| | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT |
| | phoenix.end2end.MutationStateIT |
| | phoenix.trace.PhoenixTableMetricsWriterIT |
| | phoenix.end2end.IndexScrutinyToolForTenantIT |
| | phoenix.end2end.IntArithmeticIT |
| | phoenix.schema.stats.NonTxStatsCollectorIT |
| | phoenix.end2end.RegexpSplitFunctionIT |
| | phoenix.end2end.TenantSpecificViewIndexSaltedIT |
| | phoenix.end2end.TopNIT |
| | phoenix.end2end.IndexBuildTimestampIT |
| | phoenix.end2end.PowerFunctionEnd2EndIT |
| | phoenix.end2end.index.LocalMutableTxIndexIT |
| | phoenix.end2end.ConvertTimezoneFunctionIT |
| | phoenix.end2end.index.DropColumnIT |
| | phoenix.mapreduce.PhoenixServerBuildIndexInputFormatIT |
| | phoenix.end2end.ViewIndexIdRetrieveIT |
| | phoenix.end2end.QueryIT |
| | phoenix.end2end.salted.SaltedTableUpsertSelectIT |
| | phoenix.end2end.UpdateCacheAcrossDifferentClientsIT |
| | phoenix.end2end.TenantSpecificViewIndexIT |
| | phoenix.end2end.join.HashJoinNoIndexIT |
| | phoenix.end2end.CreateSchemaIT |
| | phoenix.execute.PartialCommitIT |
| | phoenix.end2end.UseSchemaIT |
| | phoenix.schema.stats.TxStatsCollectorIT |
| | phoenix.end2end.ProjectArrayElemAfterHashJoinIT |
| | phoenix.end2end.RTrimFunctionIT |
| | phoenix.end2end.index.IndexMaintenanceIT |
| | phoenix.end2end.PhoenixTTLToolIT |
| | phoenix.end2end.AggregateIT |
| | phoenix.end2end.SequencePointInTimeIT |
| | phoenix.end2end.SumFunctionIT |
| | phoenix.end2end.index.LocalImmutableNonTxIndexIT |
| | phoenix.end2end.FlappingAlterTableIT |
| | phoenix.end2end.IndexToolForNonTxGlobalIndexIT |
| | phoenix.end2end.StringIT |
| | phoenix.end2end.PermissionNSEnabledIT |
| | phoenix.end2end.SortOrderIT |
| | phoenix.end2end.index.IndexWithTableSchemaChangeIT |
| | phoenix.end2end.FlappingLocalIndexIT |
| | phoenix.tx.FlappingTransactionIT |
| | phoenix.end2end.ViewMetadataIT |
| | phoenix.end2end.OctetLengthFunctionEnd2EndIT |
| | phoenix.end2end.IndexVerificationOldDesignIT |
| | phoenix.end2end.SqrtFunctionEnd2EndIT |
| | phoenix.end2end.index.ShortViewIndexIdIT |
| | phoenix.end2end.DropTableIT |
| | phoenix.end2end.CollationKeyFunctionIT |
| | phoenix.end2end.CbrtFunctionEnd2EndIT |
| | phoenix.end2end.QueryWithOffsetIT |
| | phoenix.end2end.SetPropertyOnNonEncodedTableIT |
| | phoenix.end2end.index.IndexRebuildIncrementDisableCountIT |
| | phoenix.end2end.AbsFunctionEnd2EndIT |
| | phoenix.end2end.DescOrderKeysIT |
| | phoenix.end2end.index.LocalIndexIT |
| | phoenix.end2end.OnDuplicateKeyIT |
| | phoenix.end2end.index.DropMetadataIT |
| | phoenix.end2end.index.LocalMutableNonTxIndexIT |
| | phoenix.end2end.DropIndexedColsIT |
| | phoenix.end2end.index.SingleCellIndexIT |
| | phoenix.end2end.index.ImmutableIndexIT |
| | phoenix.end2end.index.MutableIndexSplitReverseScanIT |
| | phoenix.end2end.index.ImmutableIndexExtendedIT |
| | phoenix.end2end.IndexToolIT |
| | phoenix.end2end.TransactionalViewIT |
| | phoenix.end2end.TenantSpecificTablesDDLIT |
| | phoenix.end2end.VariableLengthPKIT |
| | phoenix.end2end.ConcurrentMutationsExtendedIT |
| | phoenix.end2end.ParallelIteratorsIT |
| | phoenix.end2end.MigrateSystemTablesToSystemNamespaceIT |
| | phoenix.end2end.QueryDatabaseMetaDataIT |
| | phoenix.end2end.MathPIFunctionEnd2EndIT |
| | phoenix.end2end.UngroupedAggregateRegionObserverSplitFailureIT |
| | phoenix.end2end.BackwardCompatibilityIT |
| | phoenix.end2end.TenantIdTypeIT |
| | phoenix.end2end.SetPropertyOnEncodedTableIT |
| | phoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT |
| | phoenix.end2end.InstrFunctionIT |
| | phoenix.end2end.PrimitiveTypeIT |
| | phoenix.end2end.index.GlobalMutableNonTxIndexWithLazyPostBatchWriteIT |
| | phoenix.end2end.salted.SaltedTableIT |
| | phoenix.end2end.ArrayRemoveFunctionIT |
| | phoenix.end2end.DefaultColumnValueIT |
| | phoenix.end2end.CostBasedDecisionIT |
| | phoenix.end2end.SpooledTmpFileDeleteIT |
| | phoenix.end2end.LastValueFunctionIT |
| | phoenix.end2end.InQueryIT |
| | phoenix.end2end.PhoenixRuntimeIT |
| | phoenix.end2end.Array3IT |
| | phoenix.coprocessor.StatisticsCollectionRunTrackerIT |
| | phoenix.end2end.RegexBulkLoadToolIT |
| | phoenix.end2end.RegexpSubstrFunctionIT |
| | phoenix.end2end.EncodeFunctionIT |
| | phoenix.end2end.SerialIteratorsIT |
| | phoenix.end2end.IndexToolTimeRangeIT |
| | phoenix.end2end.UngroupedIT |
| | phoenix.end2end.index.MutableIndexReplicationIT |
| | phoenix.end2end.SignFunctionEnd2EndIT |
| | phoenix.end2end.MapReduceIT |
| | phoenix.end2end.RegexpReplaceFunctionIT |
| | phoenix.end2end.DropTableWithViewsIT |
| | phoenix.rpc.UpdateCacheConnectionLevelPropIT |
| | phoenix.end2end.ExpFunctionEnd2EndIT |
| | phoenix.end2end.NamespaceSchemaMappingIT |
| | phoenix.end2end.DropSchemaIT |
| | phoenix.end2end.NthValueFunctionIT |
| | phoenix.end2end.DisableLocalIndexIT |
| | phoenix.end2end.PropertiesInSyncIT |
| | phoenix.end2end.Array2IT |
| | phoenix.end2end.UpsertWithSCNIT |
| | phoenix.end2end.AlterAddCascadeIndexIT |
| | phoenix.end2end.EmptyColumnIT |
| | phoenix.end2end.DistinctCountIT |
| | phoenix.end2end.index.ViewIndexIT |
| | phoenix.end2end.EvaluationOfORIT |
| | phoenix.end2end.DerivedTableIT |
| | phoenix.end2end.QueryMoreIT |
| | phoenix.iterate.RoundRobinResultIteratorWithStatsIT |
| | phoenix.iterate.ChunkedResultIteratorIT |
| | phoenix.end2end.SCNIT |
| | phoenix.end2end.join.HashJoinCacheIT |
| | phoenix.end2end.RowValueConstructorOffsetIT |
| | phoenix.end2end.MultiCfQueryExecIT |
| | phoenix.end2end.index.txn.RollbackIT |
| | phoenix.execute.UpsertSelectOverlappingBatchesIT |
| | phoenix.end2end.join.SubqueryIT |
| | phoenix.end2end.SortMergeJoinMoreIT |
| | phoenix.end2end.SequenceBulkAllocationIT |
| | phoenix.end2end.QueryLoggerIT |
| | phoenix.end2end.Array1IT |
| | phoenix.end2end.PartialScannerResultsDisabledIT |
| | phoenix.end2end.TableSnapshotReadsMapReduceIT |
| | phoenix.end2end.IndexExtendedIT |
| | phoenix.end2end.IndexScrutinyToolIT |
| | phoenix.end2end.ExplainPlanWithStatsEnabledIT |
| | phoenix.tx.TransactionIT |
| | phoenix.end2end.index.GlobalMutableTxIndexIT |
| | phoenix.end2end.index.ImmutableIndexWithStatsIT |
| | phoenix.end2end.FirstValueFunctionIT |
| | phoenix.end2end.ArrayConcatFunctionIT |
| | phoenix.end2end.BackwardCompatibilityForSplittableSyscatIT |
| | phoenix.end2end.ExecuteStatementsIT |
| | phoenix.end2end.CountDistinctApproximateHyperLogLogIT |
| | phoenix.end2end.join.HashJoinMoreIT |
| | phoenix.end2end.PermissionsCacheIT |
| | phoenix.end2end.SystemTablesCreationOnConnectionIT |
| | TEST-[5] |
| | phoenix.end2end.ViewConcurrencyAndFailureIT |
| | phoenix.end2end.SequenceIT |
| | phoenix.schema.stats.NoOpStatsCollectorIT |
| | phoenix.end2end.InListIT |
| | phoenix.end2end.SystemCatalogRollbackEnabledIT |
| | phoenix.end2end.index.PhoenixMRJobSubmitterIT |
| | phoenix.monitoring.PhoenixMetricsDisabledIT |
| | phoenix.end2end.MD5FunctionIT |
| | phoenix.end2end.ArrayFillFunctionIT |
| | phoenix.end2end.StoreNullsPropIT |
| | phoenix.end2end.LogicalTableNameIT |
| | phoenix.end2end.NumericArithmeticIT |
| | phoenix.end2end.MaxLookbackIT |
| | phoenix.schema.stats.NamespaceEnabledStatsCollectorIT |
| | phoenix.end2end.index.InvalidIndexStateClientSideIT |
| | phoenix.end2end.ReadOnlyIT |
| | phoenix.end2end.CsvBulkLoadToolIT |
| | phoenix.rpc.PhoenixServerRpcIT |
| | phoenix.iterate.PhoenixQueryTimeoutIT |
| | phoenix.end2end.PhoenixDriverIT |
| | phoenix.end2end.LikeExpressionIT |
| | phoenix.end2end.index.MutableIndexRebuilderIT |
| | phoenix.query.MaxConcurrentConnectionsIT |
| | phoenix.end2end.MetaDataEndpointImplIT |
| | phoenix.end2end.StatsEnabledSplitSystemCatalogIT |
| | phoenix.end2end.index.MutableIndexFailureIT |
| | phoenix.end2end.index.IndexUsageIT |
| | phoenix.end2end.ParameterizedIndexUpgradeToolIT |
| | phoenix.end2end.join.SortMergeJoinNoIndexIT |
| | phoenix.end2end.NotQueryWithGlobalImmutableIndexesIT |
| | phoenix.end2end.index.MutableIndexExtendedIT |
| | phoenix.end2end.NoLookbackMutableIndexExtendedIT |
| | phoenix.tx.TxCheckpointIT |
| | phoenix.end2end.LogicalTableNameExtendedIT |
| | phoenix.end2end.index.MutableIndexFailureWithNamespaceIT |
| | phoenix.end2end.index.txn.MutableRollbackIT |
| | phoenix.end2end.DynamicFamilyIT |
| | phoenix.end2end.index.GlobalImmutableNonTxIndexIT |
| | phoenix.replication.SystemCatalogWALEntryFilterIT |
| | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT |
| | phoenix.end2end.UpsertSelectIT |
| | phoenix.end2end.UpperLowerFunctionIT |
| | phoenix.end2end.OrderByWithServerMemoryLimitIT |
| | phoenix.end2end.ViewUtilIT |
| | phoenix.end2end.ReverseFunctionIT |
| | phoenix.end2end.AppendOnlySchemaIT |
| | phoenix.end2end.index.IndexVerificationOutputRepositoryIT |
| | phoenix.end2end.TruncateFunctionIT |
| | phoenix.end2end.AggregateQueryIT |
| | phoenix.end2end.CSVCommonsLoaderIT |
| | phoenix.end2end.UpgradeNamespaceIT |
| | phoenix.end2end.ImmutableTablePropertiesIT |
| | phoenix.end2end.IndexRepairRegionScannerIT |
| | phoenix.end2end.PhoenixRowTimestampFunctionIT |
| | phoenix.end2end.ViewTTLIT |
| | phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT |
| | phoenix.end2end.SkipScanQueryIT |
| | phoenix.end2end.QueryWithTableSampleIT |
| | phoenix.end2end.CaseStatementIT |
| | phoenix.monitoring.PhoenixTableLevelMetricsIT |
| | phoenix.end2end.ExplainPlanWithStatsDisabledIT |
| | phoenix.end2end.SkipScanAfterManualSplitIT |
| | phoenix.end2end.StringToArrayFunctionIT |
| | phoenix.end2end.RebuildIndexConnectionPropsIT |
| | phoenix.end2end.DeleteIT |
| | phoenix.end2end.CustomEntityDataIT |
| | phoenix.end2end.AutoCommitIT |
| | phoenix.end2end.join.HashJoinLocalIndexIT |
| | phoenix.end2end.SpillableGroupByIT |
| | phoenix.end2end.ArithmeticQueryIT |
| | phoenix.end2end.ConcurrentMutationsIT |
| | phoenix.end2end.DynamicUpsertIT |
| | phoenix.end2end.AuditLoggingIT |
| | phoenix.end2end.DateTimeIT |
| | phoenix.end2end.TenantSpecificTablesDMLIT |
| | phoenix.end2end.AlterMultiTenantTableWithViewsIT |
| | phoenix.end2end.TimezoneOffsetFunctionIT |
| | phoenix.end2end.index.GlobalIndexOptimizationIT |
| | phoenix.rpc.PhoenixClientRpcIT |
| | phoenix.end2end.PartialResultServerConfigurationIT |
| | hadoop.hbase.regionserver.wal.WALRecoveryRegionPostOpenIT |
| | phoenix.end2end.AlterTableIT |
| | phoenix.end2end.join.SortMergeJoinLocalIndexIT |
| | phoenix.end2end.join.SortMergeJoinGlobalIndexIT |
| | phoenix.end2end.join.HashJoinGlobalIndexIT |
| | phoenix.query.ConnectionCachingIT |
| | phoenix.end2end.NotQueryWithLocalImmutableIndexesIT |
| | phoenix.end2end.CreateTableIT |
| | phoenix.end2end.ArraysWithNullsIT |
| | phoenix.end2end.IsNullIT |
| | phoenix.end2end.LastValuesFunctionIT |
| | phoenix.end2end.index.AlterIndexIT |
| | phoenix.end2end.QueryWithLimitIT |
| | phoenix.end2end.RowKeyBytesStringFunctionIT |
| | phoenix.end2end.index.GlobalIndexCheckerIT |
| | phoenix.end2end.index.txn.TxWriteFailureIT |
| | phoenix.end2end.ServerExceptionIT |
| | phoenix.schema.stats.NamespaceDisabledStatsCollectorIT |
| | phoenix.end2end.join.SubqueryUsingSortMergeJoinIT |
| | phoenix.end2end.CastAndCoerceIT |
| | phoenix.end2end.ToDateFunctionIT |
| | phoenix.end2end.ColumnProjectionOptimizationIT |
| | phoenix.end2end.CursorWithRowValueConstructorIT |
| | phoenix.end2end.ArrayPrependFunctionIT |
| | phoenix.end2end.index.ChildViewsUseParentViewIndexIT |
| | phoenix.end2end.UpsertValuesIT |
| | phoenix.end2end.QueryTimeoutIT |
| | phoenix.end2end.index.LocalImmutableTxIndexIT |
| | phoenix.end2end.join.HashJoinPersistentCacheIT |
| | phoenix.end2end.OrphanViewToolIT |
| | phoenix.end2end.OperationTimeoutWithReasonIT |
| | phoenix.end2end.DefaultPhoenixMultiViewListProviderIT |
| | phoenix.end2end.OrderByWithServerClientSpoolingDisabledIT |
| | phoenix.end2end.UpsertBigValuesIT |
| | phoenix.end2end.AlterTableWithViewsIT |
| | phoenix.end2end.index.IndexVerificationResultRepositoryIT |
| | phoenix.end2end.CoalesceFunctionIT |
| | phoenix.end2end.ProductMetricsIT |
| | phoenix.end2end.PermissionNSDisabledIT |
| | phoenix.util.CoprocessorHConnectionTableFactoryIT |
| | phoenix.end2end.MathTrigFunctionEnd2EndIT |
| | phoenix.end2end.RowValueConstructorIT |
| | phoenix.end2end.RenewLeaseIT |
| | phoenix.end2end.RangeScanIT |
| | phoenix.end2end.FunkyNamesIT |
| | phoenix.end2end.GetSetByteBitFunctionEnd2EndIT |
| | phoenix.end2end.ModulusExpressionIT |
| | phoenix.end2end.MetaDataEndPointIT |
| | phoenix.end2end.index.AsyncIndexDisabledIT |
| | phoenix.end2end.index.MutableIndexSplitForwardScanIT |
| | phoenix.end2end.ViewIT |
| | phoenix.end2end.StoreNullsIT |
| | phoenix.end2end.ConfigurableCacheIT |
| | phoenix.end2end.DynamicColumnIT |
| | phoenix.end2end.RoundFloorCeilFuncIT |
| | phoenix.end2end.AutoPartitionViewsIT |
| | phoenix.end2end.join.WhereOptimizerForJoinFiltersIT |
| | phoenix.end2end.ColumnEncodedBytesPropIT |
| | phoenix.end2end.CountDistinctCompressionIT |
| | phoenix.end2end.SystemCatalogRegionObserverIT |
| | phoenix.end2end.LocalIndexSplitMergeIT |
| | phoenix.end2end.index.GlobalMutableNonTxIndexIT |
| | phoenix.end2end.RowTimestampIT |
| | phoenix.end2end.BinaryRowKeyIT |
| | phoenix.end2end.index.IndexMetadataIT |
| | phoenix.end2end.ArrayAppendFunctionIT |
| | phoenix.end2end.UpsertSelectAutoCommitIT |
| | phoenix.end2end.UserDefinedFunctionsIT |
| | phoenix.end2end.index.GlobalImmutableTxIndexIT |
| | phoenix.end2end.FirstValuesFunctionIT |
| | phoenix.end2end.PointInTimeQueryIT |
| | phoenix.schema.tool.SchemaToolExtractionIT |
| | phoenix.monitoring.PhoenixMetricsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1288 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux c268de35903c 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 9dc5e2e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/1/testReport/ |
| Max. process+thread count | 3871 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi merged pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
yanxinyi merged pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on a change in pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#discussion_r690885652
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -648,6 +649,19 @@ public void clearTableRegionCache(byte[] tableName) throws SQLException {
connection.clearRegionCache(TableName.valueOf(tableName));
}
+ public byte[] getNextRegionStartKey(HRegionLocation regionLocation, byte[] currentKey) throws IOException {
Review comment:
updated the logic and handled the start and end empty row case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] dbwong commented on a change in pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
dbwong commented on a change in pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#discussion_r690838853
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -648,6 +649,19 @@ public void clearTableRegionCache(byte[] tableName) throws SQLException {
connection.clearRegionCache(TableName.valueOf(tableName));
}
+ public byte[] getNextRegionStartKey(HRegionLocation regionLocation, byte[] currentKey) throws IOException {
Review comment:
Are we sure this is the inconsitency? I'd rather do something more protective where we compare the successive keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#issuecomment-900921728
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 28s | 4.x passed |
| +1 :green_heart: | compile | 1m 7s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 14s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 18s | phoenix-core in 4.x has 958 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 38s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 1m 14s | phoenix-core: The patch generated 5 new + 1064 unchanged - 0 fixed = 1069 total (was 1064) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 28s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 203m 46s | phoenix-core in the patch passed. |
| +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. |
| | | 255m 11s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1288 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 460cd9696c54 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 9dc5e2e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/2/testReport/ |
| Max. process+thread count | 4741 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/2/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] dbwong commented on a change in pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
dbwong commented on a change in pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#discussion_r690838853
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -648,6 +649,19 @@ public void clearTableRegionCache(byte[] tableName) throws SQLException {
connection.clearRegionCache(TableName.valueOf(tableName));
}
+ public byte[] getNextRegionStartKey(HRegionLocation regionLocation, byte[] currentKey) throws IOException {
Review comment:
Are we sure this is the inconsitency? I'd rather do something more protective where we compare the successive keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#issuecomment-901537235
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 56s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 0s | 4.x passed |
| +1 :green_heart: | compile | 1m 7s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 14s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 47s | 4.x passed |
| +0 :ok: | spotbugs | 3m 21s | phoenix-core in 4.x has 958 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 56s | the patch passed |
| +1 :green_heart: | compile | 1m 6s | the patch passed |
| +1 :green_heart: | javac | 1m 6s | the patch passed |
| -1 :x: | checkstyle | 1m 14s | phoenix-core: The patch generated 5 new + 1064 unchanged - 0 fixed = 1069 total (was 1064) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 31s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 198m 35s | phoenix-core in the patch passed. |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| | | 245m 39s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1288 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux d7a0a0dcef49 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 9dc5e2e |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/3/artifact/yetus-general-check/output/whitespace-eol.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/3/testReport/ |
| Max. process+thread count | 5216 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1288/3/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] yanxinyi commented on a change in pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…
Posted by GitBox <gi...@apache.org>.
yanxinyi commented on a change in pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#discussion_r690885652
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -648,6 +649,19 @@ public void clearTableRegionCache(byte[] tableName) throws SQLException {
connection.clearRegionCache(TableName.valueOf(tableName));
}
+ public byte[] getNextRegionStartKey(HRegionLocation regionLocation, byte[] currentKey) throws IOException {
Review comment:
updated the logic and handled the start and end empty row case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org