Re: [PR] fix complex types returning UNKNOWN as their SQL type inference (druid)

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis commented on code in PR #16216:
URL: https://github.com/apache/druid/pull/16216#discussion_r1547164612


##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/Calcites.java:
##########
@@ -100,6 +100,15 @@ public class Calcites
   public static final SqlReturnTypeInference
       ARG1_NULLABLE_ARRAY_RETURN_TYPE_INFERENCE = new Arg1NullableArrayTypeInference();
 
+  public static SqlReturnTypeInference complexReturnTypeWithNullability(ColumnType columnType, boolean nullable)

Review Comment:
   Oh, I guess we could have defined this method on `OperatorBuilder`, similar to the others https://github.com/apache/druid/blob/master/sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java#L366



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org