[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8381: Support NOT in TimeSegmentPruner

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #8381:
URL: https://github.com/apache/pinot/pull/8381#discussion_r832529674



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/TimeSegmentPruner.java
##########
@@ -478,6 +490,25 @@ public synchronized void refreshSegment(String segment) {
     return res;
   }
 
+  /**
+   * Returns the complement (non-overlapping sorted intervals) of the given non-overlapping sorted intervals.
+   */
+  private List<Interval> getComplementSortedIntervals(List<Interval> intervals) {

Review comment:
       We don't have test for individual interval set operations currently. We may add them as a separate PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org