You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by oza <gi...@git.apache.org> on 2014/12/13 08:36:46 UTC

[GitHub] spark pull request: [SPARK-4839] Adding a documentation about dyna...

GitHub user oza opened a pull request:

    https://github.com/apache/spark/pull/3689

    [SPARK-4839] Adding a documentation about dynamic resource allocation.

    Signed-off-by: Tsuyoshi Ozawa <oz...@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oza/spark SPARK-4839

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/3689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3689
    
----
commit abc7e22fb95db2abd610a32dc3cb3dd3745fadb6
Author: Tsuyoshi Ozawa <oz...@gmail.com>
Date:   2014-12-13T07:34:25Z

    Adding a documentation about dynamic resource allocation.
    
    Signed-off-by: Tsuyoshi Ozawa <oz...@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4839][YARN] Adding a documentation abou...

Posted by oza <gi...@git.apache.org>.
Github user oza commented on the pull request:

    https://github.com/apache/spark/pull/3689#issuecomment-67195311
  
    Updated a description of dynamic resource allocation based on a comment by @ash211.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4839][YARN] Adding a documentation abou...

Posted by oza <gi...@git.apache.org>.
Github user oza closed the pull request at:

    https://github.com/apache/spark/pull/3689


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4839][YARN] Adding a documentation abou...

Posted by oza <gi...@git.apache.org>.
Github user oza commented on the pull request:

    https://github.com/apache/spark/pull/3689#issuecomment-67105316
  
    Thanks for your comment, I'm updating it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4839] Adding a documentation about dyna...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/3689#issuecomment-66868521
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4839][YARN] Adding a documentation abou...

Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/3689#issuecomment-67097670
  
    /cc @aarondav @andrewor14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4839][YARN] Adding a documentation abou...

Posted by oza <gi...@git.apache.org>.
Github user oza commented on the pull request:

    https://github.com/apache/spark/pull/3689#issuecomment-67278755
  
    @andrewor14 OK, feel free to use this PR. Closing this as duplicated one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4839][YARN] Adding a documentation abou...

Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/3689#issuecomment-67219777
  
    Hey @oza thanks for doing this. I actually intend to structure this a little differently in its own separate page and there is another JIRA (SPARK-4140) that I filed earlier for this. I'll take this up and work on it in the next day or two. In the mean time would you mind closing this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-4839][YARN] Adding a documentation abou...

Posted by ash211 <gi...@git.apache.org>.
Github user ash211 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3689#discussion_r21794489
  
    --- Diff: docs/configuration.md ---
    @@ -1142,6 +1142,55 @@ Apart from these, the following properties are also available, and may be useful
     </tr>
     </table>
     
    +#### Dynamic allocation
    +<table class="table">
    +<tr><th>Property Name</th><th>Default</th><th>Meaning</th></tr>
    +<tr>
    +  <td><code>spark.dynamicAllocation.enabled</code></td>
    +  <td>false</td>
    +  <td>
    +    Enabling dynamic resource allocation.
    --- End diff --
    
    Can you add more explanation of what dynamic resource allocation is here?  As a user unfamiliar with the feature, this description doesn't tell me enough to know whether I want to turn it on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org