[GitHub] [doris] morningman commented on a diff in pull request #16083: [improvement](memory) load support overcommit memory

[GitBox <gi...@apache.org>]

morningman commented on code in PR #16083:
URL: https://github.com/apache/doris/pull/16083#discussion_r1082723038


##########
be/src/util/mem_info.cpp:
##########
@@ -127,6 +133,18 @@ void MemInfo::process_full_gc() {
         return;
     }
     freed_mem += MemTrackerLimiter::free_top_memory_query(_s_process_full_gc_size - freed_mem);
+    if (freed_mem > _s_process_full_gc_size) {
+        return;
+    }
+    if (config::enable_query_memroy_overcommit) {
+        freed_mem += MemTrackerLimiter::free_top_overcommit_query(
+                _s_process_full_gc_size - freed_mem, MemTrackerLimiter::Type::LOAD);
+        if (freed_mem > _s_process_full_gc_size) {
+            return;
+        }
+    }
+    freed_mem += MemTrackerLimiter::free_top_memory_query(_s_process_full_gc_size - freed_mem,

Review Comment:
   I think this should be put in `if (config::enable_query_memroy_overcommit)`?
   Otherwise, if `enable_query_memroy_overcommit` is false, this will cancel the load prior to query?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org