You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 19:00:27 UTC
[GitHub] [airflow] mik-laj opened a new pull request #13517: Support Brotli compression for web views
mik-laj opened a new pull request #13517:
URL: https://github.com/apache/airflow/pull/13517
Brotli is a more modern compression algorithm that provides better compression ratios than gzip and is widely supported by browsers. If the browser does not support Brotli, another supported algorithm will be used - gzip, deflate.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13517: Support Brotli compression for web views
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13517:
URL: https://github.com/apache/airflow/pull/13517#discussion_r553271516
##########
File path: airflow/www/decorators.py
##########
@@ -62,38 +61,28 @@ def wrapper(*args, **kwargs):
return cast(T, wrapper)
-def gzipped(f: T) -> T:
+def compressed(f: T) -> T:
Review comment:
This decorator requires that we have a global variable with a Compress instance. I preferred to avoid it, so I implemented this decorator again. See: https://github.com/colour-science/flask-compress/issues/12
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #13517: Support Brotli compression for web views
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #13517:
URL: https://github.com/apache/airflow/pull/13517
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13517: Support Brotli compression for web views
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13517:
URL: https://github.com/apache/airflow/pull/13517#issuecomment-787209738
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #13517: Support Brotli compression for web views
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #13517:
URL: https://github.com/apache/airflow/pull/13517#discussion_r553255636
##########
File path: airflow/www/decorators.py
##########
@@ -62,38 +61,28 @@ def wrapper(*args, **kwargs):
return cast(T, wrapper)
-def gzipped(f: T) -> T:
+def compressed(f: T) -> T:
Review comment:
Can't we just use the decorator from flask_comrpressed rather than having to implement our own? https://github.com/colour-science/flask-compress/blob/master/flask_compress.py#L206-L215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org