You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by cm...@collab.net on 2002/01/22 13:38:34 UTC
Re: Suggestion: separating client error codes
Daniel Stenberg <da...@haxx.se> writes:
> Background:
>
> I had a go at adding the previously discussed $EDITOR feature, and it seems
> to be somewhat working here. Now I want to add a good set of error codes to
> make the client bail out nicely all over whereever an error might occur.
>
> So, where do I add these new error codes? To my surprise, we "pollute" the
> global "include/svn_error_codes.h" file with command line client errors right
> now. I don't think this is a good idea. The command line client should keep a
> private set of errors.
>
> We can't possibly have all clients add all their error codes in the
> subversion error code header file!
>
> I think the error codes in that file should apply to all functionality
> provided my subversion libraries. Functionality outside the core libraries
> should not have error codes in there.
>
> Comments?
I agree completely. Subversion should define a "client_error_begin"
that signifies the first available error code after Subversion's own
errors. Client can then define their error array to be
SVN_ERR_CLIENT_ERROR_BEGIN + 0 (+ 1, 2, 3, 4 ...).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Suggestion: separating client error codes
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Kevin Pilch-Bisson <ke...@pilch-bisson.net> writes:
> > > I agree completely. Subversion should define a "client_error_begin"
> > > that signifies the first available error code after Subversion's own
> > > errors. Client can then define their error array to be
> > > SVN_ERR_CLIENT_ERROR_BEGIN + 0 (+ 1, 2, 3, 4 ...).
> >
> > +1
> +1
+1, go for it Daniel.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Suggestion: separating client error codes
Posted by Kevin Pilch-Bisson <ke...@pilch-bisson.net>.
On Wed, Jan 23, 2002 at 09:07:18AM -0500, Garrett Rooney wrote:
> On Tue, Jan 22, 2002 at 07:38:34AM -0600, cmpilato@collab.net wrote:
> > Daniel Stenberg <da...@haxx.se> writes:
> >
> > > Background:
> > >
> > > I had a go at adding the previously discussed $EDITOR feature, and it seems
> > > to be somewhat working here. Now I want to add a good set of error codes to
> > > make the client bail out nicely all over whereever an error might occur.
> > >
> > > So, where do I add these new error codes? To my surprise, we "pollute" the
> > > global "include/svn_error_codes.h" file with command line client errors right
> > > now. I don't think this is a good idea. The command line client should keep a
> > > private set of errors.
> > >
> > > We can't possibly have all clients add all their error codes in the
> > > subversion error code header file!
> > >
> > > I think the error codes in that file should apply to all functionality
> > > provided my subversion libraries. Functionality outside the core libraries
> > > should not have error codes in there.
> > >
> > > Comments?
> >
> > I agree completely. Subversion should define a "client_error_begin"
> > that signifies the first available error code after Subversion's own
> > errors. Client can then define their error array to be
> > SVN_ERR_CLIENT_ERROR_BEGIN + 0 (+ 1, 2, 3, 4 ...).
>
> +1
+1
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson http://www.pilch-bisson.net
"Historically speaking, the presences of wheels in Unix
has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Re: Suggestion: separating client error codes
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Tue, Jan 22, 2002 at 07:38:34AM -0600, cmpilato@collab.net wrote:
> Daniel Stenberg <da...@haxx.se> writes:
>
> > Background:
> >
> > I had a go at adding the previously discussed $EDITOR feature, and it seems
> > to be somewhat working here. Now I want to add a good set of error codes to
> > make the client bail out nicely all over whereever an error might occur.
> >
> > So, where do I add these new error codes? To my surprise, we "pollute" the
> > global "include/svn_error_codes.h" file with command line client errors right
> > now. I don't think this is a good idea. The command line client should keep a
> > private set of errors.
> >
> > We can't possibly have all clients add all their error codes in the
> > subversion error code header file!
> >
> > I think the error codes in that file should apply to all functionality
> > provided my subversion libraries. Functionality outside the core libraries
> > should not have error codes in there.
> >
> > Comments?
>
> I agree completely. Subversion should define a "client_error_begin"
> that signifies the first available error code after Subversion's own
> errors. Client can then define their error array to be
> SVN_ERR_CLIENT_ERROR_BEGIN + 0 (+ 1, 2, 3, 4 ...).
+1
-garrett
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org