You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Shanedell (via GitHub)" <gi...@apache.org> on 2023/03/29 16:34:37 UTC

[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #539: Build scehma issue

Shanedell commented on code in PR #539:
URL: https://github.com/apache/daffodil-vscode/pull/539#discussion_r1152213970


##########
.github/workflows/CI.yml:
##########
@@ -117,5 +117,4 @@ jobs:
         if: runner.os != 'Linux'
       - name: Package
         run: |

Review Comment:
   Can you update this from
   
   ```yml
   run: |
     yarn package
   ```
   
   to be
   ```yml
   run: yarn package
   ```
   
   Other than that I like this PR. Once this is updated I am willing to approve!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org