[jira] [Commented] (KAFKA-6328) Exclude node groups belonging to global stores in InternalTopologyBuilder#makeNodeGroups

["Matthias J. Sax (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295412#comment-16295412 ] 

Matthias J. Sax commented on KAFKA-6328:
----------------------------------------

Thanks for the patch. Please assign the JIRA to yourself and open a PR on Github so we can review it. It's also good to update the JIRA to "Start Progress" and "Patch Available" if possible.

> Exclude node groups belonging to global stores in InternalTopologyBuilder#makeNodeGroups
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6328
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6328
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 1.0.0
>            Reporter: Guozhang Wang
>              Labels: newbie
>         Attachments: kafka-6328.diff
>
>
> Today when we group processor nodes into groups (i.e. sub-topologies), we assign the sub-topology id for global tables' dummy groups as well. As a result, the subtopology ids (and hence task ids) are not consecutive anymore. This is quite confusing for users trouble shooting and debugging; in addition, the node group for global stores are not useful as well: we simply exclude it in all the caller functions of makeNodeGroups.
> It would be better to simply exclude the global store's node groups in this function so that the subtopology ids and task ids are consecutive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)