You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/15 22:25:15 UTC
[jira] Created: (CASSANDRA-85) More tests for remove
More tests for remove
---------------------
Key: CASSANDRA-85
URL: https://issues.apache.org/jira/browse/CASSANDRA-85
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
Priority: Minor
Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-85) More tests for remove
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-85:
---------------------------------------
Assignee: Sandeep Tata
can you review this one?
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Sandeep Tata
> Priority: Minor
> Attachments: 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt, 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt, 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt, 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-85) More tests for remove
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699740#action_12699740 ]
Jonathan Ellis commented on CASSANDRA-85:
-----------------------------------------
04
waitForFlush -> forceBlockingFlush. ServerTest.cleanup now flushes and cleans out
all ColumnFamilyStores and commitlog, allowing remove tests to not step on each
others' toes (all tests pass now).
03
use isSuper instead of DatabaseDescriptor.getColumnType
02
refactor CFS constructor to not depend on DatabaseDescriptor
01
CASSANDRA-85 add testRemoveColumnFamily, testRemoveSubColumn (do not pass yet b/c
of cleanup problems)
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Minor
> Attachments: 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt, 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt, 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt, 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-85) More tests for remove
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699949#action_12699949 ]
Jonathan Ellis edited comment on CASSANDRA-85 at 4/16/09 5:46 PM:
------------------------------------------------------------------
The constructor change gets us closer to being able to write standalone test that don't pull in all of Cassandra via static dependencies. So it is related, although I did not end up using it in the remove tests.
I'm trying to strike a balance here in the patches. Sorry if I got it wrong this time.. Please realize that I have close to a dozen tickets now in some stage of review. 2x or 3x that by making things even finer-grained would exceed my ability to keep track of things.
was (Author: jbellis):
The constructor change gets us closer to being able to write standalone test that don't pull in all of Cassandra via static dependencies. So it is related, although I did not end up using it in the remove tests.
I'm trying to strike a balance here in the patches. Please realize that I have close to a dozen tickets now in some stage of review. 2x or 3x that by making things even finer-grained would exceed my ability to keep track of things.
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Sandeep Tata
> Priority: Minor
> Attachments: 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt, 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt, 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt, 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-85) More tests for remove
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699954#action_12699954 ]
Sandeep Tata commented on CASSANDRA-85:
---------------------------------------
Hmm, I don't yet follow how the constructor changes help us.
I do like the other cleanup in this patch.
Here's what I recommend: let's commit this as is. We can fix up the static method vs constructor call in a separate ticket later if needed.
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Sandeep Tata
> Priority: Minor
> Attachments: 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt, 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt, 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt, 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-85) More tests for remove
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699949#action_12699949 ]
Jonathan Ellis commented on CASSANDRA-85:
-----------------------------------------
The constructor change gets us closer to being able to write standalone test that don't pull in all of Cassandra via static dependencies. So it is related, although I did not end up using it in the remove tests.
I'm trying to strike a balance here in the patches. Please realize that I have close to a dozen tickets now in some stage of review. 2x or 3x that by making things even finer-grained would exceed my ability to keep track of things.
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Sandeep Tata
> Priority: Minor
> Attachments: 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt, 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt, 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt, 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-85) More tests for remove
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699910#action_12699910 ]
Sandeep Tata commented on CASSANDRA-85:
---------------------------------------
Looks good. All tests pass.
+1 on the added tests and the forceBlockingFlush
I'm not sure I see the advantage of switching to using a static method in ColumnFamilyStore.getColumnFamilyStore() as a factory method and leaving a package scoped constructor that is only used in this static method.
-1 on this.
For the future, perhaps it'll be easier if we separated cleanup/refactoring and adding unit tests into separate tickets? I understand that sometimes adding a test needs you to do some refactoring, but smaller, focused patches make for easier and quicker review :)
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Sandeep Tata
> Priority: Minor
> Attachments: 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt, 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt, 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt, 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-85) More tests for remove
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-85.
-------------------------------------
Resolution: Fixed
works for me. committed.
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Sandeep Tata
> Priority: Minor
> Attachments: 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt, 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt, 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt, 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-85) More tests for remove
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-85:
------------------------------------
Attachment: 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt
0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt
0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt
> More tests for remove
> ---------------------
>
> Key: CASSANDRA-85
> URL: https://issues.apache.org/jira/browse/CASSANDRA-85
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Priority: Minor
> Attachments: 0001-CASSANDRA-85-add-testRemoveColumnFamily-testRemoveSub.txt, 0002-refactor-CFS-constructor-to-not-depend-on-DatabaseDesc.txt, 0003-use-isSuper-instead-of-DatabaseDescriptor.getColumnTyp.txt, 0004-waitForFlush-forceBlockingFlush.-ServerTest.cleanu.txt
>
>
> Currently untested are removing a subcolumn from a supercolumn and removing an entire CF.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.