You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/03 15:04:00 UTC

[jira] [Commented] (FLINK-6094) Implement stream-stream proctime non-window inner join

    [ https://issues.apache.org/jira/browse/FLINK-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112882#comment-16112882 ] 

ASF GitHub Bot commented on FLINK-6094:
---------------------------------------

GitHub user hequn8128 opened a pull request:

    https://github.com/apache/flink/pull/4471

    [FLINK-6094] [table] Implement stream-stream proctime non-window inner join

    
    ## What is the purpose of the change
    
    Implement stream-stream proctime non-window inner join for table-api/sql
    
    
    ## Brief change log
    
      - Implement stream-stream inner join. `DataStreamJoinRule`, `DataStreamJoin`...
      - Implement retraction for stream-stream inner join.
      - Support state retrain time configuration for stream-stream inner join.
      - Add key extractor for `DataStreamJoin` in `UniqueKeyExtractor`.
      - Modify UniqueKeyExtractor to support cases like `select(pk as pk1, pk as pk2)`, in thoes cases, pk1 or pk2 can either be the unique key.
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - Add JoinValidation Tests 
      - Add JoinHarnessTest to test data expiration 
      - Add JoinITCase for SQL and table-api 
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): ( no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (yes)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (docs, I have checked the sql and table-api docs and find 
     the inner join has already been added)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hequn8128/flink 6094_pr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4471.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4471
    
----
commit 459c3b5b7801a15eac907ab5c11f8ca01acdc1c6
Author: 军长 <he...@alibaba-inc.com>
Date:   2017-07-30T10:45:45Z

    [FLINK-6094] [table] Implement stream-stream proctime non-window inner join

----


> Implement stream-stream proctime non-window  inner join
> -------------------------------------------------------
>
>                 Key: FLINK-6094
>                 URL: https://issues.apache.org/jira/browse/FLINK-6094
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Hequn Cheng
>
> This includes:
> 1.Implement stream-stream proctime non-window  inner join
> 2.Implement the retract process logic for join



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)