You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/08/22 03:46:42 UTC
[GitHub] [incubator-eventmesh] ruanwenjun opened a new pull request #507: [ISSUE #375] In memory as event store
ruanwenjun opened a new pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507
Add standalone connector plugin
How to use:
1. Config the connector type in eventmesh.properties
```
#connector plugin
eventMesh.connector.plugin.type=standalone
```
2. install the standalone plugin
You can add the dependency in eventmesh-runtime/build.gradle
```
implementation project(":eventmesh-connector-plugin:eventmesh-connector-standalone")
```
Or execute
```
./gradlew clean jar dist copyConnectorPlugin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f4ddc1) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/95db813a5b3f2ead93d0c75e8a7be5a872aea8d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95db813) will **increase** coverage by `0.29%`.
> The diff coverage is `20.44%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.71% +0.29%
- Complexity 328 353 +25
=============================================
Files 240 252 +12
Lines 11743 12100 +357
Branches 999 1026 +27
=============================================
+ Hits 1224 1297 +73
- Misses 10419 10694 +275
- Partials 100 109 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.78% <40.78%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `44.44% <44.44%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [95db813...1f4ddc1](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d7cc23) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/95db813a5b3f2ead93d0c75e8a7be5a872aea8d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95db813) will **increase** coverage by `0.29%`.
> The diff coverage is `20.86%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.72% +0.29%
- Complexity 328 352 +24
=============================================
Files 240 252 +12
Lines 11743 12088 +345
Branches 999 1026 +27
=============================================
+ Hits 1224 1296 +72
- Misses 10419 10684 +265
- Partials 100 108 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <38.88%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.78% <40.78%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [95db813...4d7cc23](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] tydhot commented on a change in pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#discussion_r693501546
##########
File path: eventmesh-connector-plugin/eventmesh-connector-standalone/src/main/java/org/apache/eventmesh/connector/standalone/broker/MessageQueue.java
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.connector.standalone.broker;
+
+import com.google.common.base.Preconditions;
+import org.apache.eventmesh.connector.standalone.broker.model.MessageEntity;
+
+import java.util.concurrent.locks.Condition;
+import java.util.concurrent.locks.ReentrantLock;
+
+/**
+ * This is a block queue, can get entity by offset.
+ * The queue is a FIFO data structure.
+ */
+public class MessageQueue {
+
+ public MessageEntity[] items;
+
+ private int takeIndex;
+
+ private int putIndex;
+
+ private int count;
+
+ private ReentrantLock lock;
Review comment:
maybe the lock is final is better in this queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-910167788
@xwm1992 OK, I have fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on a change in pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#discussion_r705090104
##########
File path: eventmesh-connector-plugin/eventmesh-connector-standalone/src/main/java/org/apache/eventmesh/connector/standalone/broker/task/SubScribeTask.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.connector.standalone.broker.task;
+
+import io.openmessaging.api.AsyncMessageListener;
+import io.openmessaging.api.Message;
+import org.apache.eventmesh.api.EventMeshAction;
+import org.apache.eventmesh.api.EventMeshAsyncConsumeContext;
+import org.apache.eventmesh.connector.standalone.broker.StandaloneBroker;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class SubScribeTask implements Runnable {
+
+ private String topicName;
+ private StandaloneBroker standaloneBroker;
+ private AsyncMessageListener listener;
+ private volatile boolean isRunning;
+
+ private AtomicInteger offset;
+
+ private final Logger logger = LoggerFactory.getLogger(SubScribeTask.class);
+
+ public SubScribeTask(String topicName,
+ StandaloneBroker standaloneBroker,
+ AsyncMessageListener listener) {
+ this.topicName = topicName;
+ this.standaloneBroker = standaloneBroker;
+ this.listener = listener;
+ this.isRunning = true;
+ }
+
+ @Override
+ public void run() {
+ while (isRunning) {
+ try {
+ logger.debug("execute subscribe task, topic: {}, offset: {}", topicName, offset);
+ if (offset == null) {
+ Message message = standaloneBroker.getMessage(topicName);
+ if (message != null) {
+ offset = new AtomicInteger((int) message.getOffset());
+ }
+ }
+ if (offset != null) {
+ Message message = standaloneBroker.getMessage(topicName, offset.get());
+ if (message != null) {
+ EventMeshAsyncConsumeContext consumeContext = new EventMeshAsyncConsumeContext() {
+ @Override
+ public void commit(EventMeshAction action) {
+ switch (action) {
+ case CommitMessage:
+ // update offset
+ offset.incrementAndGet();
+ logger.info("message commit, topic: {}, current offset:{}", topicName, offset.get());
+ break;
+ case ReconsumeLater:
+ // don't update offset
+ break;
+ case ManualAck:
+ // update offset
+ offset.incrementAndGet();
Review comment:
Here is the ManualAck, shouldn't update the offset after commit the message, there is an acktask in runtime, only client call this task, the offset will be increment, you can refer the `MessageAckTask`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-909235634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun removed a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
ruanwenjun removed a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-909365402
@xwm1992 Thanks, I have fixed this problem, but it seems that the consumer has another problem, I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-909235634
I try to use standalone mode to pub/sub. There is a `topic not exist exception` while client subscribe the topic, please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-911297604
@Jackzeng1224 Thanks, but this error also appears, when I am using rocketmq.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d81759) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/106ca96b5b4e4ad0107c6cd68ce46ff7819533f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (106ca96) will **increase** coverage by `0.32%`.
> The diff coverage is `21.36%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.75% +0.32%
- Complexity 328 353 +25
=============================================
Files 241 253 +12
Lines 11737 12102 +365
Branches 1001 1028 +27
=============================================
+ Hits 1224 1302 +78
- Misses 10411 10690 +279
- Partials 102 110 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <38.88%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.78% <40.78%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [106ca96...7d81759](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-909235634
I try to use standalone mode to pub/sub. There is a `topic not exist exception` while client subscribe the topic, please have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Jackzeng1224 commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
Jackzeng1224 commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-911091813
@ruanwenjun hello,When I test it will appear "SimpleSubClientImpl(SimpleSubClientImpl.java:169)-msg ignored|HEARTBEAT_RESPONSE|Package{header=Header{cmd=HEARTBEAT_RESPONSE, code=0, msg='success', seq='6462122308'), body=null}"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e3349e) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/95db813a5b3f2ead93d0c75e8a7be5a872aea8d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95db813) will **increase** coverage by `0.28%`.
> The diff coverage is `20.16%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.71% +0.28%
- Complexity 328 352 +24
=============================================
Files 240 252 +12
Lines 11743 12100 +357
Branches 999 1026 +27
=============================================
+ Hits 1224 1296 +72
- Misses 10419 10696 +277
- Partials 100 108 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <38.88%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.78% <40.78%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [95db813...5e3349e](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun removed a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
ruanwenjun removed a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-909365402
@xwm1992 Thanks, I have fixed this problem, but it seems that the consumer has another problem, I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d81759) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/106ca96b5b4e4ad0107c6cd68ce46ff7819533f3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (106ca96) will **increase** coverage by `0.32%`.
> The diff coverage is `21.36%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.75% +0.32%
- Complexity 328 353 +25
=============================================
Files 241 253 +12
Lines 11737 12102 +365
Branches 1001 1028 +27
=============================================
+ Hits 1224 1302 +78
- Misses 10411 10690 +279
- Partials 102 110 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <38.88%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.78% <40.78%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [106ca96...7d81759](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#discussion_r705227392
##########
File path: eventmesh-connector-plugin/eventmesh-connector-standalone/src/main/java/org/apache/eventmesh/connector/standalone/broker/task/SubScribeTask.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.connector.standalone.broker.task;
+
+import io.openmessaging.api.AsyncMessageListener;
+import io.openmessaging.api.Message;
+import org.apache.eventmesh.api.EventMeshAction;
+import org.apache.eventmesh.api.EventMeshAsyncConsumeContext;
+import org.apache.eventmesh.connector.standalone.broker.StandaloneBroker;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class SubScribeTask implements Runnable {
+
+ private String topicName;
+ private StandaloneBroker standaloneBroker;
+ private AsyncMessageListener listener;
+ private volatile boolean isRunning;
+
+ private AtomicInteger offset;
+
+ private final Logger logger = LoggerFactory.getLogger(SubScribeTask.class);
+
+ public SubScribeTask(String topicName,
+ StandaloneBroker standaloneBroker,
+ AsyncMessageListener listener) {
+ this.topicName = topicName;
+ this.standaloneBroker = standaloneBroker;
+ this.listener = listener;
+ this.isRunning = true;
+ }
+
+ @Override
+ public void run() {
+ while (isRunning) {
+ try {
+ logger.debug("execute subscribe task, topic: {}, offset: {}", topicName, offset);
+ if (offset == null) {
+ Message message = standaloneBroker.getMessage(topicName);
+ if (message != null) {
+ offset = new AtomicInteger((int) message.getOffset());
+ }
+ }
+ if (offset != null) {
+ Message message = standaloneBroker.getMessage(topicName, offset.get());
+ if (message != null) {
+ EventMeshAsyncConsumeContext consumeContext = new EventMeshAsyncConsumeContext() {
+ @Override
+ public void commit(EventMeshAction action) {
+ switch (action) {
+ case CommitMessage:
+ // update offset
+ offset.incrementAndGet();
+ logger.info("message commit, topic: {}, current offset:{}", topicName, offset.get());
+ break;
+ case ReconsumeLater:
+ // don't update offset
+ break;
+ case ManualAck:
+ // update offset
+ offset.incrementAndGet();
Review comment:
OK, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #507: [WIP][ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-910067768
There is still have an exception during client subscribe to eventmesh runtime server, server didn't send the `subscribe response` cmd to the client, which cause the client operation time out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c96fad7) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/95db813a5b3f2ead93d0c75e8a7be5a872aea8d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95db813) will **increase** coverage by `0.28%`.
> The diff coverage is `20.16%`.
> :exclamation: Current head c96fad7 differs from pull request most recent head bb4e370. Consider uploading reports for the commit bb4e370 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.71% +0.28%
- Complexity 328 352 +24
=============================================
Files 240 252 +12
Lines 11743 12100 +357
Branches 999 1026 +27
=============================================
+ Hits 1224 1296 +72
- Misses 10419 10696 +277
- Partials 100 108 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <38.88%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.78% <40.78%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [95db813...bb4e370](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36bf0b1) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/ed578334350212b95ef4b9bf86c2f1b4913e85af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ed57833) will **increase** coverage by `0.33%`.
> The diff coverage is `21.48%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.76% +0.33%
- Complexity 328 353 +25
=============================================
Files 241 253 +12
Lines 11737 12100 +363
Branches 1001 1028 +27
=============================================
+ Hits 1224 1302 +78
- Misses 10411 10688 +277
- Partials 102 110 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <38.88%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.25% <40.25%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ed57833...36bf0b1](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on a change in pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#discussion_r705090104
##########
File path: eventmesh-connector-plugin/eventmesh-connector-standalone/src/main/java/org/apache/eventmesh/connector/standalone/broker/task/SubScribeTask.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.connector.standalone.broker.task;
+
+import io.openmessaging.api.AsyncMessageListener;
+import io.openmessaging.api.Message;
+import org.apache.eventmesh.api.EventMeshAction;
+import org.apache.eventmesh.api.EventMeshAsyncConsumeContext;
+import org.apache.eventmesh.connector.standalone.broker.StandaloneBroker;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class SubScribeTask implements Runnable {
+
+ private String topicName;
+ private StandaloneBroker standaloneBroker;
+ private AsyncMessageListener listener;
+ private volatile boolean isRunning;
+
+ private AtomicInteger offset;
+
+ private final Logger logger = LoggerFactory.getLogger(SubScribeTask.class);
+
+ public SubScribeTask(String topicName,
+ StandaloneBroker standaloneBroker,
+ AsyncMessageListener listener) {
+ this.topicName = topicName;
+ this.standaloneBroker = standaloneBroker;
+ this.listener = listener;
+ this.isRunning = true;
+ }
+
+ @Override
+ public void run() {
+ while (isRunning) {
+ try {
+ logger.debug("execute subscribe task, topic: {}, offset: {}", topicName, offset);
+ if (offset == null) {
+ Message message = standaloneBroker.getMessage(topicName);
+ if (message != null) {
+ offset = new AtomicInteger((int) message.getOffset());
+ }
+ }
+ if (offset != null) {
+ Message message = standaloneBroker.getMessage(topicName, offset.get());
+ if (message != null) {
+ EventMeshAsyncConsumeContext consumeContext = new EventMeshAsyncConsumeContext() {
+ @Override
+ public void commit(EventMeshAction action) {
+ switch (action) {
+ case CommitMessage:
+ // update offset
+ offset.incrementAndGet();
+ logger.info("message commit, topic: {}, current offset:{}", topicName, offset.get());
+ break;
+ case ReconsumeLater:
+ // don't update offset
+ break;
+ case ManualAck:
+ // update offset
+ offset.incrementAndGet();
Review comment:
Here is the ManualAck, shouldn't update the offset after commit the message, there is an acktask in runtime, only client call this task, the offset will be increment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-909365402
@xwm1992 Thanks, I have fixed this problem, but it seems that the consumer has another problem, I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bb4e370) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/95db813a5b3f2ead93d0c75e8a7be5a872aea8d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95db813) will **increase** coverage by `0.28%`.
> The diff coverage is `20.16%`.
> :exclamation: Current head bb4e370 differs from pull request most recent head 1f4ddc1. Consider uploading reports for the commit 1f4ddc1 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.71% +0.28%
- Complexity 328 352 +24
=============================================
Files 240 252 +12
Lines 11743 12100 +357
Branches 999 1026 +27
=============================================
+ Hits 1224 1296 +72
- Misses 10419 10696 +277
- Partials 100 108 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <38.88%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.78% <40.78%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [95db813...1f4ddc1](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-909365402
@xwm1992 Thanks, I have fixed this problem, but it seems that the consumer has another problem, I am not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#discussion_r693506512
##########
File path: eventmesh-connector-plugin/eventmesh-connector-standalone/src/main/java/org/apache/eventmesh/connector/standalone/broker/MessageQueue.java
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.connector.standalone.broker;
+
+import com.google.common.base.Preconditions;
+import org.apache.eventmesh.connector.standalone.broker.model.MessageEntity;
+
+import java.util.concurrent.locks.Condition;
+import java.util.concurrent.locks.ReentrantLock;
+
+/**
+ * This is a block queue, can get entity by offset.
+ * The queue is a FIFO data structure.
+ */
+public class MessageQueue {
+
+ public MessageEntity[] items;
+
+ private int takeIndex;
+
+ private int putIndex;
+
+ private int count;
+
+ private ReentrantLock lock;
Review comment:
Thanks, agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507#issuecomment-903209370
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#507](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fcdf62) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/95db813a5b3f2ead93d0c75e8a7be5a872aea8d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95db813) will **increase** coverage by `0.29%`.
> The diff coverage is `20.86%`.
> :exclamation: Current head 7fcdf62 differs from pull request most recent head 4d7cc23. Consider uploading reports for the commit 4d7cc23 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/graphs/tree.svg?width=650&height=150&src=pr&token=IfkrgV55GT&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #507 +/- ##
=============================================
+ Coverage 10.42% 10.72% +0.29%
- Complexity 328 352 +24
=============================================
Files 240 252 +12
Lines 11743 12088 +345
Branches 999 1026 +27
=============================================
+ Hits 1224 1296 +72
- Misses 10419 10684 +265
- Partials 100 108 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...connector/standalone/MessagingAccessPointImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvTWVzc2FnaW5nQWNjZXNzUG9pbnRJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...onnector/standalone/broker/task/SubScribeTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svU3ViU2NyaWJlVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZUNvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../consumer/StandaloneMeshMQPushConsumerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvY29uc3VtZXIvU3RhbmRhbG9uZU1lc2hNUVB1c2hDb25zdW1lckFkYXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...lone/producer/StandaloneMeshMQProducerAdaptor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZU1lc2hNUVByb2R1Y2VyQWRhcHRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nector/standalone/producer/StandaloneProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcHJvZHVjZXIvU3RhbmRhbG9uZVByb2R1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/resource/StandaloneConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvcmVzb3VyY2UvU3RhbmRhbG9uZUNvbm5lY3RvclJlc291cmNlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nnector/standalone/broker/model/MessageEntity.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL21vZGVsL01lc3NhZ2VFbnRpdHkuamF2YQ==) | `38.88% <38.88%> (ø)` | |
| [...mesh/connector/standalone/broker/MessageQueue.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `40.78% <40.78%> (ø)` | |
| [...tandalone/broker/task/HistoryMessageClearTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1zdGFuZGFsb25lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY29ubmVjdG9yL3N0YW5kYWxvbmUvYnJva2VyL3Rhc2svSGlzdG9yeU1lc3NhZ2VDbGVhclRhc2suamF2YQ==) | `50.00% <50.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/507/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [95db813...4d7cc23](https://codecov.io/gh/apache/incubator-eventmesh/pull/507?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #507: [ISSUE #375] In memory as event store
Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #507:
URL: https://github.com/apache/incubator-eventmesh/pull/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org