You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/18 16:03:45 UTC

[GitHub] [shardingsphere] huangdx0726 opened a new pull request, #20282: Refactor DistSQL drop scaling jobId to clean scaling jobId

huangdx0726 opened a new pull request, #20282:
URL: https://github.com/apache/shardingsphere/pull/20282

   Fixes #20275 .
   
   Changes proposed in this pull request:
   -
   -  replace drop to clean in some files
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] yx9o commented on a diff in pull request #20282: Refactor DistSQL drop scaling jobId to clean scaling jobId

Posted by GitBox <gi...@apache.org>.
yx9o commented on code in PR #20282:
URL: https://github.com/apache/shardingsphere/pull/20282#discussion_r949349686


##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-parser/src/main/antlr4/imports/migration/RALStatement.g4:
##########
@@ -39,8 +39,8 @@ stopScaling
     : STOP SCALING jobId
     ;
 
-dropScaling
-    : DROP SCALING jobId
+cleanScaling
+    : CLEAN SCALING jobId

Review Comment:
   Please add `CLEAN` in the `Keyword.g4`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] yx9o commented on a diff in pull request #20282: Refactor DistSQL drop scaling jobId to clean scaling jobId

Posted by GitBox <gi...@apache.org>.
yx9o commented on code in PR #20282:
URL: https://github.com/apache/shardingsphere/pull/20282#discussion_r949346557


##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/migration/CleanMigrationStatementTestCase.java:
##########
@@ -28,7 +28,7 @@
  * Drop migration statement test case.

Review Comment:
   Please update comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] yx9o commented on a diff in pull request #20282: Refactor DistSQL drop scaling jobId to clean scaling jobId

Posted by GitBox <gi...@apache.org>.
yx9o commented on code in PR #20282:
URL: https://github.com/apache/shardingsphere/pull/20282#discussion_r949342281


##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/main/java/org/apache/shardingsphere/migration/distsql/handler/update/CleanMigrationUpdater.java:
##########
@@ -20,22 +20,22 @@
 import org.apache.shardingsphere.data.pipeline.api.MigrationJobPublicAPI;
 import org.apache.shardingsphere.data.pipeline.api.PipelineJobPublicAPIFactory;
 import org.apache.shardingsphere.infra.distsql.update.RALUpdater;
-import org.apache.shardingsphere.migration.distsql.statement.DropMigrationStatement;
+import org.apache.shardingsphere.migration.distsql.statement.CleanMigrationStatement;
 
 /**
  * Drop migration updater.

Review Comment:
   Please update comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] sandynz merged pull request #20282: Refactor DistSQL drop scaling jobId to clean scaling jobId

Posted by GitBox <gi...@apache.org>.
sandynz merged PR #20282:
URL: https://github.com/apache/shardingsphere/pull/20282


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #20282: Refactor DistSQL drop scaling jobId to clean scaling jobId

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20282:
URL: https://github.com/apache/shardingsphere/pull/20282#issuecomment-1220236025

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20282?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#20282](https://codecov.io/gh/apache/shardingsphere/pull/20282?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23f90b0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7e688039a5b6b011adf17725160503de7d391396?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e68803) will **increase** coverage by `0.03%`.
   > The diff coverage is `26.31%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #20282      +/-   ##
   ============================================
   + Coverage     60.89%   60.92%   +0.03%     
   - Complexity     2430     2433       +3     
   ============================================
     Files          3885     3886       +1     
     Lines         54765    54774       +9     
     Branches       9320     9322       +2     
   ============================================
   + Hits          33348    33373      +25     
   + Misses        18565    18547      -18     
   - Partials       2852     2854       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...dler/update/AddMigrationSourceResourceUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0FkZE1pZ3JhdGlvblNvdXJjZVJlc291cmNlVXBkYXRlci5qYXZh) | `0.00% <ø> (ø)` | |
   | [.../distsql/handler/update/ApplyMigrationUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0FwcGx5TWlncmF0aW9uVXBkYXRlci5qYXZh) | `0.00% <ø> (ø)` | |
   | [.../distsql/handler/update/CleanMigrationUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0NsZWFuTWlncmF0aW9uVXBkYXRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...on/distsql/handler/update/MigrateTableUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL01pZ3JhdGVUYWJsZVVwZGF0ZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [.../distsql/handler/update/ResetMigrationUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL1Jlc2V0TWlncmF0aW9uVXBkYXRlci5qYXZh) | `0.00% <ø> (ø)` | |
   | [...r/update/RestoreMigrationSourceWritingUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL1Jlc3RvcmVNaWdyYXRpb25Tb3VyY2VXcml0aW5nVXBkYXRlci5qYXZh) | `0.00% <ø> (ø)` | |
   | [.../distsql/handler/update/StartMigrationUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL1N0YXJ0TWlncmF0aW9uVXBkYXRlci5qYXZh) | `0.00% <ø> (ø)` | |
   | [...dler/update/StopMigrationSourceWritingUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL1N0b3BNaWdyYXRpb25Tb3VyY2VXcml0aW5nVXBkYXRlci5qYXZh) | `0.00% <ø> (ø)` | |
   | [...n/distsql/handler/update/StopMigrationUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLWhhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21pZ3JhdGlvbi9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL1N0b3BNaWdyYXRpb25VcGRhdGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../parser/core/MigrationDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1zaGFyZGluZy1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWlncmF0aW9uL2Rpc3RzcWwvcGFyc2VyL2NvcmUvTWlncmF0aW9uRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [12 more](https://codecov.io/gh/apache/shardingsphere/pull/20282/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] sandynz commented on pull request #20282: Refactor DistSQL drop scaling jobId to clean scaling jobId

Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #20282:
URL: https://github.com/apache/shardingsphere/pull/20282#issuecomment-1220117074

   Hi @huangdx0726 , there's SQLParsingException of `clean-scaling`.
   You could install `ANTLR v4` plugin (IDEA for example).
   Open `migration/RALStatement.g4`; Select `cleanScaling`, select `Run Rule cleanScaling` in right click menu; Input test DistSQL; Then you could find whether DistSQL parsing work or not.
   <img width="1027" alt="图片" src="https://user-images.githubusercontent.com/42492540/185518653-202baf14-357b-48f9-a31e-fd0ec54f37cf.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] yx9o commented on a diff in pull request #20282: Refactor DistSQL drop scaling jobId to clean scaling jobId

Posted by GitBox <gi...@apache.org>.
yx9o commented on code in PR #20282:
URL: https://github.com/apache/shardingsphere/pull/20282#discussion_r949346230


##########
shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/migration/update/CleanMigrationStatementAssert.java:
##########
@@ -31,7 +31,7 @@
 /**
  * Drop migration statement assert.

Review Comment:
   Please update comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org