You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2011/06/05 15:03:34 UTC

Re: svn commit: r1132376 - /subversion/trunk/configure.ac

stsp@apache.org wrote on Sun, Jun 05, 2011 at 12:11:02 -0000:
> -AC_PATH_PROGS(RUBY, ruby1.8 ruby18 ruby, none)
> +AC_PATH_PROGS(RUBY, $RUBY ruby, none)

Could you re-add ruby1.8?  I added it because in some environment I had
no 'ruby' binary but did have a 'ruby1.8' binary...

Re: svn commit: r1132376 - /subversion/trunk/configure.ac

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Daniel Shahaf wrote on Sun, Jun 05, 2011 at 18:50:59 +0300:
> Stefan Sperling wrote on Sun, Jun 05, 2011 at 17:43:22 +0200:
> > On Sun, Jun 05, 2011 at 06:15:29PM +0300, Daniel Shahaf wrote:
> > > I don't think checking for ruby20 ruby2.0 ruby19 ruby1.9 ruby18 ruby1.8
> > > is too much of a problem.  We already do this for some other
> > > dependencies:
> > 
> > OK, then let's make it do what Arfrever suggested:
> > 
> > AC_PATH_PROGS(RUBY, $RUBY ruby ruby1.9 ruby19 ruby1.8 ruby18, none)
> > AC_PATH_PROGS(RDOC, $RDOC rdoc rdoc1.9 rdoc19 rdoc1.8 rdoc18, none)
> 
> +1
> 

r1132464.

Re: svn commit: r1132376 - /subversion/trunk/configure.ac

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Stefan Sperling wrote on Sun, Jun 05, 2011 at 17:43:22 +0200:
> On Sun, Jun 05, 2011 at 06:15:29PM +0300, Daniel Shahaf wrote:
> > I don't think checking for ruby20 ruby2.0 ruby19 ruby1.9 ruby18 ruby1.8
> > is too much of a problem.  We already do this for some other
> > dependencies:
> 
> OK, then let's make it do what Arfrever suggested:
> 
> AC_PATH_PROGS(RUBY, $RUBY ruby ruby1.9 ruby19 ruby1.8 ruby18, none)
> AC_PATH_PROGS(RDOC, $RDOC rdoc rdoc1.9 rdoc19 rdoc1.8 rdoc18, none)

+1


Re: svn commit: r1132376 - /subversion/trunk/configure.ac

Posted by Stefan Sperling <st...@elego.de>.
On Sun, Jun 05, 2011 at 06:15:29PM +0300, Daniel Shahaf wrote:
> I don't think checking for ruby20 ruby2.0 ruby19 ruby1.9 ruby18 ruby1.8
> is too much of a problem.  We already do this for some other
> dependencies:

OK, then let's make it do what Arfrever suggested:

AC_PATH_PROGS(RUBY, $RUBY ruby ruby1.9 ruby19 ruby1.8 ruby18, none)
AC_PATH_PROGS(RDOC, $RDOC rdoc rdoc1.9 rdoc19 rdoc1.8 rdoc18, none)

Re: svn commit: r1132376 - /subversion/trunk/configure.ac

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Stefan Sperling wrote on Sun, Jun 05, 2011 at 17:07:35 +0200:
> On Sun, Jun 05, 2011 at 05:57:26PM +0300, Daniel Shahaf wrote:
> > Stefan Sperling wrote on Sun, Jun 05, 2011 at 16:21:53 +0200:
> > > On Sun, Jun 05, 2011 at 04:03:34PM +0300, Daniel Shahaf wrote:
> > > > stsp@apache.org wrote on Sun, Jun 05, 2011 at 12:11:02 -0000:
> > > > > -AC_PATH_PROGS(RUBY, ruby1.8 ruby18 ruby, none)
> > > > > +AC_PATH_PROGS(RUBY, $RUBY ruby, none)
> > > > 
> > > > Could you re-add ruby1.8?  I added it because in some environment I had
> > > > no 'ruby' binary but did have a 'ruby1.8' binary...
> > > 
> > > And 'env RUBY=ruby1.8 ./configure' is not good enough?
> > > Some people have ruby18, or ruby1.9, or ruby19, or in the future
> > > maybe even ruby2020 or whatever. Why special-case one of these
> > > in the configure script?
> > 
> > I didn't suggest special-casing them: if the bindings are compatible
> > with 1.9, we could use
> > 
> > AC_PATH_PROGS(RUBY, $RUBY ruby ruby1.9 ruby1.8, none)
> 
> Then why add not ruby19 and ruby18 as well?
> This is system-specific stuff that needs to be configurable, not
> hard-coded in our scripts.
> The list of rubys is going to grow over time and I don't think that's
> a good idea. I'm glad Arfrever pointed out a way to avoid this problem.

I don't think checking for ruby20 ruby2.0 ruby19 ruby1.9 ruby18 ruby1.8
is too much of a problem.  We already do this for some other
dependencies:

Index: configure.ac
===================================================================
--- configure.ac	(revision 1131437)
+++ configure.ac	(working copy)
@@ -104,6 +104,7 @@ AC_PATH_PROG(PKG_CONFIG, pkg-config)
 # Either a space-separated list of allowable Neon versions, or "any" to
 # mean allow anything.
 NEON_ALLOWED_LIST="0\.25 0\.26 0\.27\.2 0\.28 0\.29"
+NEON_ALLOWED_LIST="0\.29 0\.28 0\.27\.2 0\.26 0\.25"
 NEON_RECOMMENDED_VER="0.29.0"
 NEON_URL="http://www.webdav.org/neon/neon-${NEON_RECOMMENDED_VER}.tar.gz"
 dnl You can skip the neon version check only if you know what you are doing 

Re: svn commit: r1132376 - /subversion/trunk/configure.ac

Posted by Stefan Sperling <st...@elego.de>.
On Sun, Jun 05, 2011 at 05:57:26PM +0300, Daniel Shahaf wrote:
> Stefan Sperling wrote on Sun, Jun 05, 2011 at 16:21:53 +0200:
> > On Sun, Jun 05, 2011 at 04:03:34PM +0300, Daniel Shahaf wrote:
> > > stsp@apache.org wrote on Sun, Jun 05, 2011 at 12:11:02 -0000:
> > > > -AC_PATH_PROGS(RUBY, ruby1.8 ruby18 ruby, none)
> > > > +AC_PATH_PROGS(RUBY, $RUBY ruby, none)
> > > 
> > > Could you re-add ruby1.8?  I added it because in some environment I had
> > > no 'ruby' binary but did have a 'ruby1.8' binary...
> > 
> > And 'env RUBY=ruby1.8 ./configure' is not good enough?
> > Some people have ruby18, or ruby1.9, or ruby19, or in the future
> > maybe even ruby2020 or whatever. Why special-case one of these
> > in the configure script?
> 
> I didn't suggest special-casing them: if the bindings are compatible
> with 1.9, we could use
> 
> AC_PATH_PROGS(RUBY, $RUBY ruby ruby1.9 ruby1.8, none)

Then why add not ruby19 and ruby18 as well?
This is system-specific stuff that needs to be configurable, not
hard-coded in our scripts.
The list of rubys is going to grow over time and I don't think that's
a good idea. I'm glad Arfrever pointed out a way to avoid this problem.

Re: svn commit: r1132376 - /subversion/trunk/configure.ac

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Stefan Sperling wrote on Sun, Jun 05, 2011 at 16:21:53 +0200:
> On Sun, Jun 05, 2011 at 04:03:34PM +0300, Daniel Shahaf wrote:
> > stsp@apache.org wrote on Sun, Jun 05, 2011 at 12:11:02 -0000:
> > > -AC_PATH_PROGS(RUBY, ruby1.8 ruby18 ruby, none)
> > > +AC_PATH_PROGS(RUBY, $RUBY ruby, none)
> > 
> > Could you re-add ruby1.8?  I added it because in some environment I had
> > no 'ruby' binary but did have a 'ruby1.8' binary...
> 
> And 'env RUBY=ruby1.8 ./configure' is not good enough?
> Some people have ruby18, or ruby1.9, or ruby19, or in the future
> maybe even ruby2020 or whatever. Why special-case one of these
> in the configure script?

I didn't suggest special-casing them: if the bindings are compatible
with 1.9, we could use

AC_PATH_PROGS(RUBY, $RUBY ruby ruby1.9 ruby1.8, none)

Re: svn commit: r1132376 - /subversion/trunk/configure.ac

Posted by Stefan Sperling <st...@elego.de>.
On Sun, Jun 05, 2011 at 04:03:34PM +0300, Daniel Shahaf wrote:
> stsp@apache.org wrote on Sun, Jun 05, 2011 at 12:11:02 -0000:
> > -AC_PATH_PROGS(RUBY, ruby1.8 ruby18 ruby, none)
> > +AC_PATH_PROGS(RUBY, $RUBY ruby, none)
> 
> Could you re-add ruby1.8?  I added it because in some environment I had
> no 'ruby' binary but did have a 'ruby1.8' binary...

And 'env RUBY=ruby1.8 ./configure' is not good enough?
Some people have ruby18, or ruby1.9, or ruby19, or in the future
maybe even ruby2020 or whatever. Why special-case one of these
in the configure script?