You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ol...@apache.org on 2016/04/08 11:43:50 UTC
svn commit: r1738225 - in
/sling/trunk/bundles/commons/org.apache.sling.commons.messaging: ./
src/main/java/org/apache/sling/commons/messaging/
Author: olli
Date: Fri Apr 8 09:43:50 2016
New Revision: 1738225
URL: http://svn.apache.org/viewvc?rev=1738225&view=rev
Log:
SLING-5643 Provide a simple messaging API
* use CompletableFuture instead of Future
* remove Failure
Removed:
sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/Failure.java
Modified:
sling/trunk/bundles/commons/org.apache.sling.commons.messaging/README.md
sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/MessageService.java
sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/Result.java
Modified: sling/trunk/bundles/commons/org.apache.sling.commons.messaging/README.md
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/org.apache.sling.commons.messaging/README.md?rev=1738225&r1=1738224&r2=1738225&view=diff
==============================================================================
--- sling/trunk/bundles/commons/org.apache.sling.commons.messaging/README.md (original)
+++ sling/trunk/bundles/commons/org.apache.sling.commons.messaging/README.md Fri Apr 8 09:43:50 2016
@@ -13,11 +13,3 @@ Simple API for sending *message*âs
`Result<T>`
-----------
* `getMessage():T` - should return a serialized form of the sent *message*
- * `hasFailures():boolean` - should return `true` in case of failures, `false` otherwise
- * `getFailures():Collection<Failure>` - should return the failures occurred when processing or sending the message
-
-`Failure`
----------
- * `getCode():String` - should return a failure code when available, e.g. an [SMTP Status Code](https://tools.ietf.org/html/rfc5248)
- * `getType():String` - should return a failure type when available, e.g. invalid input (message too big) or transport failure (host unavailable)
- * `getMessage():String` - should return a human readable failure message
Modified: sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/MessageService.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/MessageService.java?rev=1738225&r1=1738224&r2=1738225&view=diff
==============================================================================
--- sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/MessageService.java (original)
+++ sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/MessageService.java Fri Apr 8 09:43:50 2016
@@ -19,7 +19,7 @@
package org.apache.sling.commons.messaging;
import java.util.Map;
-import java.util.concurrent.Future;
+import java.util.concurrent.CompletableFuture;
import javax.annotation.Nonnull;
@@ -33,7 +33,7 @@ public interface MessageService {
* @param recipient the recipient of the message
* @return result of sending the message
*/
- Future<Result> send(@Nonnull final String message, @Nonnull final String recipient);
+ CompletableFuture<Result> send(@Nonnull final String message, @Nonnull final String recipient);
/**
* @param message the message to send
@@ -41,6 +41,6 @@ public interface MessageService {
* @param data additional information (e.g. attachments) and/or parameters (e.g. sender) for the message
* @return result of sending the message
*/
- Future<Result> send(@Nonnull final String message, @Nonnull final String recipient, @Nonnull final Map data);
+ CompletableFuture<Result> send(@Nonnull final String message, @Nonnull final String recipient, @Nonnull final Map data);
}
Modified: sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/Result.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/Result.java?rev=1738225&r1=1738224&r2=1738225&view=diff
==============================================================================
--- sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/Result.java (original)
+++ sling/trunk/bundles/commons/org.apache.sling.commons.messaging/src/main/java/org/apache/sling/commons/messaging/Result.java Fri Apr 8 09:43:50 2016
@@ -18,8 +18,6 @@
*/
package org.apache.sling.commons.messaging;
-import java.util.Collection;
-
import javax.annotation.CheckForNull;
import org.osgi.annotation.versioning.ProviderType;
@@ -32,14 +30,4 @@ public interface Result<T> {
*/
@CheckForNull T getMessage();
- /**
- * @return <code>true</code> in case of failures, <code>false</code> otherwise
- */
- boolean hasFailures();
-
- /**
- * @return the failures occurred when processing or sending the message
- */
- @CheckForNull Collection<Failure> getFailures();
-
}